Skip to content

Commit 3c8d33a

Browse files
authored
Merge pull request react-native-maps#2702 from jerolimov/fix-rn59rc-compile-issues
Enable RN projects to define the Android AppCompat Library version (and fix dependency issues with RN 0.59 RC)
2 parents ebc3f0b + 6d2dfed commit 3c8d33a

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

lib/android/build.gradle

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ apply from: 'gradle-maven-push.gradle'
44
def DEFAULT_COMPILE_SDK_VERSION = 27
55
def DEFAULT_BUILD_TOOLS_VERSION = "27.0.3"
66
def DEFAULT_TARGET_SDK_VERSION = 27
7+
def DEFAULT_ANDROID_SUPPORT_LIB_VERSION = "27.0.2"
78
def DEFAULT_GOOGLE_PLAY_SERVICES_VERSION = "16.0.1"
89
def DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION = "16.0.0"
910
def DEFAULT_ANDROID_MAPS_UTILS_VERSION = "0.5+"
@@ -45,12 +46,14 @@ android {
4546
}
4647

4748
dependencies {
49+
def supportLibVersion = safeExtGet('supportLibVersion', DEFAULT_ANDROID_SUPPORT_LIB_VERSION)
4850
def googlePlayServicesVersion = safeExtGet('googlePlayServicesVersion', DEFAULT_GOOGLE_PLAY_SERVICES_VERSION)
4951
// Variable lookup order : googlePlayServicesMapsVersion > googlePlayServicesVersion > DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION
5052
def googlePlayServicesMapsVersion = safeExtGet('googlePlayServicesMapsVersion', safeExtGet('googlePlayServicesVersion', DEFAULT_GOOGLE_PLAY_SERVICES_MAPS_VERSION))
5153
def androidMapsUtilsVersion = safeExtGet('androidMapsUtilsVersion', DEFAULT_ANDROID_MAPS_UTILS_VERSION)
5254

5355
compileOnly "com.facebook.react:react-native:+"
56+
implementation "com.android.support:appcompat-v7:$supportLibVersion"
5457
implementation "com.google.android.gms:play-services-base:$googlePlayServicesVersion"
5558
implementation "com.google.android.gms:play-services-maps:$googlePlayServicesMapsVersion"
5659
implementation "com.google.maps.android:android-maps-utils:$androidMapsUtilsVersion"

0 commit comments

Comments
 (0)