[marker flicker] Fix flicker of map pins on state change (react-native-maps#728)

mlanter · gilbox · commit ab1ecd8da04f · 2016-11-03T18:36:06.000-07:00
diff --git a/components/decorateMapComponent.js b/components/decorateMapComponent.js
@@ -48,8 +48,8 @@ export default function decorateMapComponent(Component, { componentType, provide
     if (components[provider]) return components[provider];
 
     if (provider === PROVIDER_DEFAULT) {
-      components.default = getDefaultComponent();
-      return components.default;
+      components[PROVIDER_DEFAULT] = getDefaultComponent();
+      return components[PROVIDER_DEFAULT];
     }
 
     const providerInfo = providers[provider];
@@ -62,8 +62,8 @@ export default function decorateMapComponent(Component, { componentType, provide
         components[provider] = requireNativeComponent(componentName, Component);
       }
     } else { // (platformSupport === USES_DEFAULT_IMPLEMENTATION)
-      if (!components.default) components.default = getDefaultComponent();
-      components[provider] = components.default;
+      if (!components[PROVIDER_DEFAULT]) components[PROVIDER_DEFAULT] = getDefaultComponent();
+      components[provider] = components[PROVIDER_DEFAULT];
     }
 
     return components[provider];

Original file line number	Diff line number	Diff line change
`@@ -48,8 +48,8 @@ export default function decorateMapComponent(Component, { componentType, provide`
`48`	`48`	`if (components[provider]) return components[provider];`
`49`	`49`
`50`	`50`	`if (provider === PROVIDER_DEFAULT) {`
`51`		`- components.default = getDefaultComponent();`
`52`		`- return components.default;`
	`51`	`+ components[PROVIDER_DEFAULT] = getDefaultComponent();`
	`52`	`+ return components[PROVIDER_DEFAULT];`
`53`	`53`	`}`
`54`	`54`
`55`	`55`	`const providerInfo = providers[provider];`
`@@ -62,8 +62,8 @@ export default function decorateMapComponent(Component, { componentType, provide`
`62`	`62`	`components[provider] = requireNativeComponent(componentName, Component);`
`63`	`63`	`}`
`64`	`64`	`} else { // (platformSupport === USES_DEFAULT_IMPLEMENTATION)`
`65`		`- if (!components.default) components.default = getDefaultComponent();`
`66`		`- components[provider] = components.default;`
	`65`	`+ if (!components[PROVIDER_DEFAULT]) components[PROVIDER_DEFAULT] = getDefaultComponent();`
	`66`	`+ components[provider] = components[PROVIDER_DEFAULT];`
`67`	`67`	`}`
`68`	`68`
`69`	`69`	`return components[provider];`