-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stable API for Spotless? #579
Comments
Oooh this is related: diffplug/spotless#419 |
@swankjesse yes, it's been reported on the Spotless side. As you probably know, we somewhat recently inherited the ktlint codebase, and breaking compatibility with Spotless was totally unintentional, as we didn't even realize the dependency existed. Moving forward, we'll be much more careful at talking to dependent projects if we ever decide to make a breaking API change. For this particular issue, I'd prefer it be fixed on the Spotless API, as the API broke because we moved a lot of code into the |
Would you be working on a PR in the spotless repo to fix this? @shashachu |
I've PR'd a fix in diffplug/spotless#469 |
Ktlint has not yet reached stable 1.0.0 release meaning that most probably we may change api in the future. Though we will try to do it gracefully through deprecation and not break it in each release. |
We upgraded from ktlint 0.33.0 to 0.34.2 and it caused our Spotless plugin to crash:
Would it be worthwhile to lock down the API that Spotless uses to talk to Ktlint, so that Ktlint changes can’t break Spotless? Until that’s done it’s annoying to keep either project up-to-date.
The text was updated successfully, but these errors were encountered: