Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option for prompt before auto-correct #79

Closed
jbarr21 opened this issue Sep 7, 2017 · 5 comments
Closed

Option for prompt before auto-correct #79

jbarr21 opened this issue Sep 7, 2017 · 5 comments

Comments

@jbarr21
Copy link

jbarr21 commented Sep 7, 2017

The ktlint -F option to auto-correct is great, but can you please add the ability to confirm before auto-correcting an instance of an issue? Something like the attached image would be nice to see how your source file will be modified.

checkstyle-autofix
@ZacSweers
Copy link

alternatively - would you be open to a PR adding this option?

@shyiko
Copy link
Collaborator

shyiko commented Sep 7, 2017 •
edited
Loading

@jbarr21 @hzsweers absolutely!
If you have the time to submit a PR - that would be perfect (it would definitely be merged in). If not, (sooner or later) I'll take care of it myself.

@JelloRanger JelloRanger mentioned this issue Apr 22, 2018
Merged
@blcooley
Copy link

@shyiko Doing a little code triage. It looks like this issue can be closed since the PR has been merged.

@jbarr21
Copy link
Author

jbarr21 commented Jan 4, 2019

that PR is separate, this issue still exists

@paul-dingemans
Copy link
Collaborator

Closing issue due to lack of progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@shyiko @blcooley @ZacSweers @jbarr21 @paul-dingemans