circular references in type-helpers.d.ts using tsc 3.4rc

[harrybin]

Using tsc 3.4rc a circular reference is detected in type-helpers.d.ts.

tanspiler error message:
_node_modules/typesafe-actions/dist/type-helpers.d.ts
(1,21): Type alias 'ActionType' circularly references itself.

[harrybin]

suggested solution: (see: microsoft/TypeScript#30483)

export declare type ActionType<ActionCreatorOrMap> = ActionCreatorOrMap extends ActionCreator<StringType> ? ReturnType<ActionCreatorOrMap> : {
    1: ActionCreators<ActionCreatorOrMap[keyof ActionCreatorOrMap]>;
    0: never;
}[ActionCreatorOrMap extends object ? 1 : 0];

type ActionCreators<T> = T extends any ? ActionType<T> : never;

updated/corrected 29.03.

[AustinBrunkhorst]

Were you able to get the proposed solution to work? I still get the circular reference error with typescript@3.2.4

[fightingcat]

Sorry for the incorrect code, I recently only use my phone viewing github. This should be working:

export declare type ActionType<ActionCreatorOrMap> = ActionCreatorOrMap extends ActionCreator<StringType> ? ReturnType<ActionCreatorOrMap> : {
    1: ActionCreators<ActionCreatorOrMap[keyof ActionCreatorOrMap]>;
    0: never;
}[ActionCreatorOrMap extends object ? 1 : 0];

type ActionCreators<T> = T extends any ? ActionType<T> : never;

[AustinBrunkhorst]

@fightingcat that solution is brilliant! I forgot objects were fair game at compile time. TypeScript is pretty neat 👍. Thanks for sharing

[ethanneff]

Typescript 3.4.1 just released. Confirming typesafe-actions breaks with this update.

 FAIL  src/components/Markdown/__tests__/index.tsx
  ● Test suite failed to run

    TypeScript diagnostics (customize using `[jest-config].globals.ts-jest.diagnostics` option):
    src/screens/Debug/screens/Checklists/models/Item/index.tsx:21:27 - error TS2315: Type 'ActionType' is not generic.

     21 export type ItemActions = ActionType<
                                  ~~~~~~~~~~~
     22   | typeof createItem
        ~~~~~~~~~~~~~~~~~~~~~
    ... 
     25   | typeof toggleActiveItem
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~
     26 >;
        ~

Current solution is to revert to "typescript": "3.3.4000"

[pwentz]

I'm also running into the same issue @ethanneff is seeing. Looks like TypeScript 3.4.1 breaks ActionType. Looks like the new TS version no longer allows types to circularly reference themselves:

type ActionType<ActionCreatorOrMap> = any
Type alias 'ActionType' circularly references itself.ts(2456)

[piotrwitek]

@fightingcat thanks for the suggested solution it looks good 👍
I have published a new version typesafe-actions@3.3.0-rc containing @fightingcat fix.
Updated the codesandbox project and all is working great.

[piotrwitek]

Related TS issues:
microsoft/TypeScript#29511
microsoft/TypeScript#30188