-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make actions compatible with new Redux Toolkit guidance on TypeScript usage #230
Comments
@andrewcraswell has funded $200.00 to this issue.
|
Let me experiment with this idea and we'll look into what is possible. |
@andrewcraswell has cancelled funding for this issue.(Cancelled amount: $200.00) See it on IssueHunt |
@andrewcraswell has funded $50.00 to this issue.
|
I still think this is a useful feature, but I found a workaround by reusing some of the types from the Redux Toolkit directly. Going to reduce the bounty on this, and convert some of it to a direct donation. |
Why do we need feature parity with redux toolkit? This is the original library and I personally like this interface better. |
It's definitely not feature parity, it's making sure things that are built with the official Toolkit are not broken in this library. Essentially, why I had to migrate away from Is there something specific you like better about not including the |
I like |
Hey! |
I had forgotten about this, but it is still funded. I'm not sure how relevant it is anymore, given that Redux Toolkit has had multiple major releases since. But if an implementation for this is submitted, I'll honor it. |
@AndrewCraswell for the record, we've had multiple minor releases of RTK, but no major releases :) we're actually about to publish RTK 2.0 hopefully in the next few weeks, though! |
In case anyone is still interested, I've made the necessary code changes in a branch here. I just don't understand enough about dts-jest to get a PR in 😅 Feel free to use! |
@EskiMojo14 thanks I'll open PR, if tests are passing I'll consider merging |
Is your feature request related to a real problem or use-case?
The Redux team has released the Redux Toolkit library for its v1 release in Oct, 2019. This simplifies implementation scenarios with Redux, and they're encouraging users to adopt it for many scenarios. However, their
Action
type is not fully compatible withtypesafe-actions
.The Redux documentation describes how actions should be able to be used with
createReducer
:They achieve this by having all their
Action
s extend theBaseActionCreator
type which adds atype
property and amatch
function for easier integration with Redux tooling.[see code]
I'm building a library that uses both the Redux Toolkit, and
typesafe-actions
, but I'm concerned that none of the actions I create withtypesafe-actions
will be usable in applications using the official Redux Toolkit.Describe a solution including usage in code example
Seems like the actions from
typesafe-actions
could extend the same properties the Redux Toolkit does, and we could benefit with interoperability and the better type safety as described by the Redux docs.Who does this impact? Who is this for?
Users of the Redux Toolkit, or building libraries which should interop with official Redux tooling.
This could also positively impact the following issue: #214
IssueHunt Summary
Backers (Total: $50.00)
Become a backer now!
Or submit a pull request to get the deposits!
Tips
IssueHunt has been backed by the following sponsors. Become a sponsor
The text was updated successfully, but these errors were encountered: