3.6.0 bug

[steida]

I just updated and my code is broken. I extracted the problematic part.

interface NextLinkProps2 {
  prefetch?: boolean;
  shallow?: boolean;
  scroll?: boolean;
  replace?: boolean;
  onError?(error: any): void;
  href?: string;
  as?: string;
  passHref?: boolean;
  children: React.ReactElement;
}

type AppHref = {
    pathname: "/";
}

export type LinkProps = Assign<
  Overwrite<
    Omit<NextLinkProps2, 'passHref'>,
    {
      // Allow string etc.
      children: ReactNode;
      // Make href required and typed.
      href: AppHref;
    }
  >,
  {
    accessible?: boolean;
    download?: string;
    // style?: StyleProp<TextStyle>;
    // activeStyle?: StyleProp<TextStyle>;
    // We use it for manual focus.
    nativeID?: string;
  }
>;

const foo: LinkProps = { prefetch: true, href: { pathname: '/' } };

Type '{ prefetch: true; href: { pathname: "/"; }; }' is missing the following properties from type 'Pick<Pick<Pick<Pick<Omit<NextLinkProps2, "passHref">, "prefetch" | "shallow" | "scroll" | "replace" | "onError" | "as"> & Pick<{ children: ReactNode; href: { pathname: "/"; } | { pathname: "/me"; } | { ...; } | { ...; } | ({ ...; } & { ...; }); }, "href" | "children">, "prefetch" |

[piotrwitek]

Hey @steida
New Omit is not preserving an optional property modifier.

I'll fall back to my previous implementation to fix the issue.

Now the other problem is that the new Omit is a built-in TypeScript type coming in v3.5 which is apparently broken and I wonder if there is a bug filled for it.

[piotrwitek]

@steida Also there is a bug in your code snippet: Property 'children' is missing in type '{ prefetch: true; href: { pathname: "/"; }; }' but required

[piotrwitek]

Fixed by https://github.com/piotrwitek/utility-types/releases/tag/v3.6.1