Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigInt Support #86

Closed
9SMTM6 opened this issue Jun 18, 2019 · 1 comment · Fixed by #87
Closed

BigInt Support #86

9SMTM6 opened this issue Jun 18, 2019 · 1 comment · Fixed by #87

Comments

@9SMTM6
Copy link
Contributor

9SMTM6 commented Jun 18, 2019

Is your feature request related to a real problem or use-case?

Adding BigInt to the Primitive type as its slated to become one.

Describe a solution including usage in code example

type Primitive = number | boolean | string | symbol | bigint

Who does this impact? Who is this for?

Users using the Stage 3 Proposal of Bigint and Typescript >=3.2

Describe alternatives you've considered (optional)

As I'm not sure how good support for the (JS, not the TS kind of 'overload') typeof operator of eventually employed polyfills is, and how older TS implementations behave with this unknown type, we might want to hold back on that for now, or guard this implementation.

Additional context (optional)

[Partially Linked in the text before]

@piotrwitek
Copy link
Owner

Hey @9SMTM6, thanks for the proposal, I think it's a valid suggestion and JS shouldn't be a concern of this library as we're not using it and consumer is responsible for its own polyfills.

Accepting PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants