Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement rpc interfaces that update the project data. #620

Merged
merged 3 commits into from
Aug 14, 2020
Merged

Implement rpc interfaces that update the project data. #620

merged 3 commits into from
Aug 14, 2020

Conversation

gkuga
Copy link
Contributor

@gkuga gkuga commented Aug 13, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot pipecd-bot requested review from cakecatz and nghialv August 13, 2020 11:05
pipecd-bot
pipecd-bot reviewed Aug 13, 2020
View reviewed changes
Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.42%. This pull request decreases coverage by -0.05%.

File Function Base Head Diff
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectStaticUser -- 0.00% +0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectSingleSignOn -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectStaticUser -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectSingleSignOn -- 0.00% +0.00%
pkg/datastore/projectstore.go projectStore.UpdateProject -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.GetProject 0.00% 0.00% +0.00%
pkg/app/api/service/webservice/service.pb.auth.go authorizer.Authorize 0.00% 0.00% +0.00%

pipecd-bot
pipecd-bot reviewed Aug 14, 2020
View reviewed changes
Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.40%. This pull request decreases coverage by -0.07%.

File Function Base Head Diff
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.EnableStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.DisableStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectSingleSignOn -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.EnableStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.DisableStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectSingleSignOn -- 0.00% +0.00%
pkg/datastore/projectstore.go projectStore.UpdateProject -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.GetProject 0.00% 0.00% +0.00%
pkg/app/api/service/webservice/service.pb.auth.go authorizer.Authorize 0.00% 0.00% +0.00%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.40%. This pull request decreases coverage by -0.07%.

File Function Base Head Diff
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.EnableStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.DisableStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/fake_web_api.go FakeWebAPI.UpdateProjectSingleSignOn -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.EnableStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.DisableStaticAdmin -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.UpdateProjectSingleSignOn -- 0.00% +0.00%
pkg/datastore/projectstore.go projectStore.UpdateProject -- 0.00% +0.00%
pkg/app/api/api/web_api.go WebAPI.GetProject 0.00% 0.00% +0.00%
pkg/app/api/service/webservice/service.pb.auth.go authorizer.Authorize 0.00% 0.00% +0.00%

@nghialv
Copy link
Member

nghialv commented Aug 14, 2020

Thank you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit ccd696f into master Aug 14, 2020
@pipecd-bot pipecd-bot deleted the project branch August 14, 2020 03:35
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details 
Error: unabled to push rendered files to destination

@pipecd-bot pipecd-bot mentioned this pull request Aug 20, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nghialv nghialv nghialv left review comments

@pipecd-bot pipecd-bot pipecd-bot left review comments

@cakecatz cakecatz Awaiting requested review from cakecatz

Assignees
No one assigned
Labels
approved area/api release-note-none size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkuga @pipecd-bot @nghialv