Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some links to detail pages #625

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Add some links to detail pages #625

merged 2 commits into from
Aug 14, 2020

Conversation

cakecatz
Copy link
Contributor

What this PR does / why we need it:

Application Detail

image

Deployment Detail

image

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@cakecatz cakecatz requested review from nghialv and nakabonne August 14, 2020 05:59
@pipecd-bot pipecd-bot requested review from asukaleido and gkuga August 14, 2020 05:59
@cakecatz cakecatz changed the title Add links to detail pages Add some links to detail pages Aug 14, 2020
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.38%. This pull request does not change code coverage.

@cakecatz
Copy link
Contributor Author

@nghialv Updated.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 21.38%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Aug 14, 2020

Thanh you.
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit b7f2392 into master Aug 14, 2020
@pipecd-bot pipecd-bot deleted the detail-links branch August 14, 2020 11:07
@pipecd-bot
Copy link
Collaborator

TEMPLATE

failed to handle template rule examples

Details
Error: unabled to push rendered files to destination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants