Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to disable drift-detection feature for each kind of application from Piped configuration #4508

Closed
nghialv opened this issue Jul 18, 2023 · 6 comments
Assignees
Labels

Comments

@nghialv
Copy link
Member

nghialv commented Jul 18, 2023

What would you like to be added:

Why is this needed:

For example, in Terraform, that feature is still under Alpha status. It could cause numerous bugs and performance downgrades. Therefore, it should be disabled by default.

@nghialv nghialv added the kind/enhancement New feature or request label Jul 18, 2023
@kentakozuka kentakozuka self-assigned this Jul 20, 2023
@kentakozuka
Copy link
Member

kentakozuka commented Jul 21, 2023

While this feature is enabled by default now, disabling it by default affect existing users.
So how about adding an option to opt-out drift detections?
Which level of config is better to set?;

  • piped config (if disabled, all terraform drift detections are disabled)
  • application config (if disalbed, drift detection of the target application is disabled)

@kentakozuka
Copy link
Member

@khanhtc1202 wdyt?

@khanhtc1202
Copy link
Member

khanhtc1202 commented Jul 21, 2023

@kentakozuka Yes, it should be a configurable option for users who want to make this feature turning off. 👍

Which level of config is better to set?;

I think it's better to make it application config first, then add to piped configuration (if needed) since the piped is designed to control many applications at once, and disabling this feature of one piped may affect many unexpected applications due to users may forget which applications is handling by that piped. Of course, in the current usecase, we want to off that feature due to the piped usage, but the feature showing on the UI is part of the application, thus this is easier to understand if we make it on/off switch by the application configuration.

Nah, changed my mind. I think it should be piped configuration, and make it turning on by default.

@kentakozuka
Copy link
Member

OK. Let me add the option to piped config 👍

Copy link
Contributor

This issue is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 18, 2024
Copy link
Contributor

This issue was closed because it has been stalled for 7 days with no activity. Feel free to reopen if still applicable.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants