Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Support OIDC for the SSO #4906

Closed
t-kikuc opened this issue May 6, 2024 · 4 comments · Fixed by #5008
Closed

[feat] Support OIDC for the SSO #4906

t-kikuc opened this issue May 6, 2024 · 4 comments · Fixed by #5008
Assignees
Labels
area/server kind/enhancement New feature or request

Comments

@t-kikuc
Copy link
Member

t-kikuc commented May 6, 2024

What would you like to be added:

Support OIDC for Control Plane's SSO.

Why is this needed:

Currently, only GitHub and Google are supported for the SSO.
However, some users want to use the SSO with other general protocols(OIDC, OAuth, SAML, LDAP, ...), especially those who need to use their internal auth system.

@t-kikuc
Copy link
Member Author

t-kikuc commented May 6, 2024

@kumo-rn5s will try this issue, thanks!

@t-kikuc t-kikuc assigned t-kikuc and unassigned t-kikuc May 8, 2024
@kumo-rn5s
Copy link
Contributor

@t-kikuc Thank you.
I will open the PR this month.

@khanhtc1202
Copy link
Member

@kumo-rn5s Thanks a lot for having interest 😄 Please ping us here if you need any help while implementing this 🤝

@khanhtc1202 khanhtc1202 added the kind/enhancement New feature or request label May 9, 2024
@khanhtc1202 khanhtc1202 moved this to Todo in v0.48.0 May 9, 2024
@kumo-rn5s
Copy link
Contributor

kumo-rn5s commented May 28, 2024

The source code about this feature itself is complete, and I am currently conducting integration tests with the following provider.

  • Keycloak
  • Cognito
  • okta

However, debugging the control plane is taking longer than expected, and it seems unlikely that we will make it in time for v0.48.0.

By the way, if you have any efficient debugging methods for the control plane, please let me know. It would be helpful if there is a way to run the debug based on VSCode.

@t-kikuc t-kikuc removed this from v0.48.0 May 28, 2024
@khanhtc1202 khanhtc1202 moved this to 📋 New in ROADMAP Jun 28, 2024
@Warashi Warashi moved this from 📋 New to 🏗 Upcoming in ROADMAP Jul 3, 2024
@khanhtc1202 khanhtc1202 removed this from ROADMAP Jul 5, 2024
@khanhtc1202 khanhtc1202 moved this to In Progress in v0.49.0 Jul 5, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in v0.49.0 Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/server kind/enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants