Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sendTransaction does not support nonce parameter #98

Open
ghost opened this issue Sep 18, 2017 · 1 comment
Open

sendTransaction does not support nonce parameter #98

ghost opened this issue Sep 18, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 18, 2017

  • py-geth Version: x.x.x
  • go-ethereum Version: x.x.x
  • Python Version: 3.6.2
  • OS: osx

What was wrong?

When passing a custom nonce to web3.eth.sendTransaction, an _send_transaction() got an unexpected keyword argument 'nonce' exception is raised. It is probably because the:

    def _send_transaction(self, _from=None, to=None, gas=None, gas_price=None,
                          value=0, data=b''):

method does not have a nonce keyword argument.

If it is too complicated too implement it perfectly, maybe it should just compare the nonce passed with the next nonce available and just throw an exception if it's not equal...? I wanted to unit-test a piece of code which explicitly passes nonces in order to do some dynamic gas price manipulation, but I cannot because of the above :(

Cute Animal Picture

image

@ghost
Copy link
Author

ghost commented Oct 1, 2017

Actually, it works if I initialize eth-testrpc by:

    web3 = Web3(EthereumTesterProvider())

but fails if I do:

    web3 = Web3(TestRPCProvider("127.0.0.1", 12349))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants