Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 404 and other error pages #104

Open
anewuser opened this issue Jul 30, 2022 · 2 comments
Open

Improve 404 and other error pages #104

anewuser opened this issue Jul 30, 2022 · 2 comments

Comments

@anewuser
Copy link
Contributor

Example: https://www.pipes.digital/test

404

@onli
Copy link
Member

onli commented Jul 30, 2022

Good idea! :)

Hey, just so that it is spoken out: If you wanted to implement some of those suggestion, please feel formally invited. Not saying I won't do it, but I wouldn't mind PRs on top of these good suggestions!

@anewuser anewuser changed the title Improve 404 error pages Improve 404 and other error pages Aug 1, 2022
@anewuser
Copy link
Contributor Author

anewuser commented Aug 2, 2022

You may want to set up different messages and/or redirect to different pages depending on the request. These should check whether the pipe exists before trying to process them:

You can first verify the length of the ID. If it's longer than X characters, don't even connect to the database to look it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants