Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alt-enter in preferences #1040

Closed
lalomartins opened this issue Feb 3, 2016 · 10 comments
Closed

Alt-enter in preferences #1040

lalomartins opened this issue Feb 3, 2016 · 10 comments

Comments

@lalomartins
Copy link

In the preferences panel, there are settings for what happens when I open a new tab in a variety of ways (awesome). But the way I usually do it is with alt-enter in the address bar, and there's no setting for that 😿 Not super high priority, but would be nice.

@piroor
Copy link
Owner

piroor commented Feb 10, 2016

TST doesn't provide any option for the feature but my another addon "New Tab from Location Bar" https://addons.mozilla.org/firefox/addon/new-tab-from-location-bar/ provides a similar option. I hope that it may help you.

@lalomartins
Copy link
Author

That's nice, and I'll give it a try. But, opening new tabs with alt-enter is built into the browser, so TST should certainly support it; I can't agree with the “out of purpose” tag. From a design perspective, there's no substantial difference between location-alt-enter and ctrl-t.

@lalomartins
Copy link
Author

I tried the other extension. It doesn't do anything remotely like what I want.

@piroor
Copy link
Owner

piroor commented Feb 11, 2016

The tag means "it is done by another addon" for now. (I think I should create a new tag.)

@lalomartins
Copy link
Author

Then it's incorrect, because it's not at all done by the other addon 😸

@lalomartins
Copy link
Author

The other extension does some clever heuristic based on whether the new URL is in the same site… or you can make it always open in a new tab. In both cases, alt inverts the behaviour (although I had to look in the source code to discover that). None of these things is what I need.

Let me try to explain the use case.

Until last week, when I was working on a project, I'd switch to that project's tab group, and work there. Opening a new tab (no matter how I do it) would almost all of the time be related to the current work, and it would open at the end of the current group, which is almost always what I want.

Now, tab groups are going away, so I'm trying alternatives. TST provides what I needed plus a lot more, so it's so far my favourite. So now, when I'm working on a project, I'll be in that project's subtree. Then, most of the interaction I do with new tabs works exactly how I want, with two exceptions:

  1. When I want to look up something new, I press ctrl-L, type something, then alt-enter. This goes to the end of the tab bar; it should go to the end of the current tree level. This operation is almost completely equivalent to opening a new tab by ctrl-T, so it stands to reason it should follow the “Open new blank tab as” setting, or at least have its own preference.
  2. (Unrelated to this ticket) ctrl-click/middle-click on a link, or target="_blank", opens as a child, I'd prefer a sibling.

@lalomartins
Copy link
Author

Anyway, I'm getting used to ctrl-T instead, so not too high priority. But for consistency, I still think it should be the case.

@piroor
Copy link
Owner

piroor commented Feb 11, 2016

OK, I agree that TST should have the option. However I won't implement it by my hand (for now), because I already created another addon "New Tab from Location Bar" which opens new child tabs without the Alt key - it is revolutionary solution for me. In my usecase, I always open new child tabs for same domain and new orphan tabs for URLs not related to the current tab. Even if the new option appear on TST, I won't use it - because I already know there is more useful solution for me. Currently I have very very less time to maintain addons, so I hope to concentrate about things I really need.

But, It is also true that not all TST users think so - including you. So I've decided to introduce new tag "need contribution" for such topics: "TST should have the feature but I have less motivation". Please fork this repository under your account, implement the feature by your hand, and send it as a pull request :) Then I'll merge it. Or, I possibly rewrite the code to match to existing codes - it will take only lesser time than implementing it by my hand from scratch.

@lalomartins
Copy link
Author

That's a great tag to have 👍 I might give it a shot, although Firefox code scares me. I already had a look around your sources, anyway.

Thanks.

@piroor
Copy link
Owner

piroor commented Oct 22, 2018

TST 0.19.x is already obsolete, so I close this.

@piroor piroor closed this as completed Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants