feat: add option to disable run/wait time recording #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
reviewed
Feb 21, 2024
| @@ -206,7 +208,8 @@ const kDefaultOptions : FilledOptions = { | |||
| taskQueue: new ArrayTaskQueue(), | |||
| niceIncrement: 0, | |||
| trackUnmanagedFds: true, | |||
| closeTimeout: 30000 | |||
| closeTimeout: 30000, | |||
| recordTiming: true | |||
There was a problem hiding this comment.
I'll prepare a PR to set this to false, as soon for v5
An additional `Piscina` constructor option is now available named `recordTiming` which can be used to control the underlying recording of wait and run times via Node.js histograms. By default this option is `true` to retain existing behavior but can be set to `false` to disable recording. The `Piscina` instance properties `runTime`, `waitTime`, and `utilization` will not be available if this option is disabled.
clydin
force-pushed
the
record-timing-option
branch
from
0c3912b to
cb85293
Compare
metcoder95
approved these changes
Feb 21, 2024
metcoder95
pushed a commit
that referenced
this pull request
Mar 10, 2024
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An additional
Piscinaconstructor option is now available namedrecordTimingwhich can be used to control the underlying recording of wait and run times via Node.js histograms. By default this option istrueto retain existing behavior but can be set tofalseto disable recording. ThePiscinainstance propertiesrunTime,waitTime, andutilizationwill not be available if this option is disabled.For longer lived processes or usage that does not rely on the time information, this removes the continuous storage of the information from memory.