Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIF export fails if image contains more than 256 colors #621

Closed
juliandescottes opened this issue Jan 24, 2017 · 1 comment
Closed

GIF export fails if image contains more than 256 colors #621

juliandescottes opened this issue Jan 24, 2017 · 1 comment

Comments

@juliandescottes
Copy link
Collaborator

STRs:

  • Import the following image in piskel:
    image

  • export as GIF

The export fails and generates an invalid GIF.

CurrentColorsService::getColors always returns an array of colors limited to the 100 colors displayed in the UI for the current colors palette. But here we need to know if the image contains more than 256 colors or not, as it changes the way we generate the GIF in GifExportController

@bbaliguet
Copy link

Very beautiful piece of art ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants