Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mimic the Counter interface #5

Open
piskvorky opened this issue Sep 2, 2017 · 3 comments
Open

Mimic the Counter interface #5

piskvorky opened this issue Sep 2, 2017 · 3 comments

Comments

@piskvorky
Copy link
Owner

Wrap the low-level implementations (min count sketch, hash tables for key iteration...) in a Counter interface. The goal is to make Counter <-> Bounter switch trivial for users.

Methods that cannot be implemented due to algorithmic constraints (key iteration with min count sketch etc) should raise a NotImplementedError with a clear error message.

@piskvorky piskvorky assigned isamaru and unassigned isamaru Sep 2, 2017
@piskvorky
Copy link
Owner Author

@isamaru what's the status here? Are we raising NotImplementedError consistently?

If not, can you list what needs to be done, so others can take this over?

@souravsingh
Copy link

I would be interested to pick this up. We just need to refactor the API to make it similar to Counter, right?

@menshikh-iv
Copy link
Contributor

@souravsingh yes, but please finish your current sLDA project first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants