Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare gensim 3.8.3 #2820

Closed
mpenkov opened this issue May 2, 2020 · 7 comments
Closed

Prepare gensim 3.8.3 #2820

mpenkov opened this issue May 2, 2020 · 7 comments
Labels
housekeeping internal tasks and processes

Comments

@mpenkov
Copy link
Collaborator

mpenkov commented May 2, 2020

OK guys, looks like we're getting close to releasing this thing. I've just updated the CHANGELOG - @piskvorky please have a look and make any changes as necessary. Each update will require a re-run of the CI and a rebuild of the wheels, so please keep that in mind.

Some other relevant things to check:

I've gone through the above myself and think like we're ready to release. @piskvorky @menshikh-iv Please let me know if you feel the same and we'll get this thing out the door.

@menshikh-iv
Copy link
Contributor

@mpenkov I merged piskvorky/gensim-wheels#1, so, after build done (~6h, thanks to Appveyour and wheelhouse_uploader bug), we will be ready to release.

I think we are ready

@piskvorky
Copy link
Owner

piskvorky commented May 3, 2020

I went through the tickets yesterday, all good.

Except I saw this new comment in the diff:
Screen Shot 2020-05-03 at 09 15 51

and went to look at the similarities.nmslib module and that's another rabbit hole: lots of little fixes, possibly buggy. I'll open a PR soon, but nothing critical for 3.8.3, let's go ahead with the release.

@piskvorky
Copy link
Owner

piskvorky commented May 3, 2020

I also replaced all references to MacPython on the Release checklist with our new mirror.

@menshikh-iv
Copy link
Contributor

menshikh-iv commented May 3, 2020

@piskvorky about nmslib: this stuff NEVER works on py2 as I investigate, but works on python3.
Current absolute_import is the simplest workaround for this problem (and will be no needed when we drop py2)

@piskvorky
Copy link
Owner

piskvorky commented May 3, 2020

Yes, I saw. The bug was nothing major in the end, I opened the PR: #2821.

@mpenkov up to you whether we include that in 3.8.3 or not, WDYT?

@mpenkov
Copy link
Collaborator Author

mpenkov commented May 3, 2020

Let's leave it out, it's not critical.

@mpenkov
Copy link
Collaborator Author

mpenkov commented May 4, 2020

OK, we're done!

Huge thanks to @menshikh-iv for "help" (he really did most of the work) with this release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping internal tasks and processes
Projects
None yet
Development

No branches or pull requests

3 participants