Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration and regression tests #151

Open
menshikh-iv opened this issue Nov 30, 2017 · 2 comments
Open

Add integration and regression tests #151

menshikh-iv opened this issue Nov 30, 2017 · 2 comments
Assignees
Labels
housekeeping issues for the smart_open team to deal with internally

Comments

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Nov 30, 2017

Right now, for testing smart_open (local file part) - it is not enough to run only tests from smart_open, needs to run gensim tests with smart_open from master (so I caught a bug today - hotfix #150).

Need to look at gensim usage of smart_open and add tests according to this behavior (better - something more "general" for all readers/writers, because the tests are rather monotonous).

CC: @mpenkov

@menshikh-iv menshikh-iv changed the title Add tests for preventing regression Add integration and regression tests Dec 6, 2017
@menshikh-iv
Copy link
Contributor Author

menshikh-iv commented Dec 6, 2017

What's need to implement

General

  • S3

    • Run all tests with real amazon S3
    • Reconfigure Travis, add job for amazon (think about distinct account, encrypt API keys, etc)
    • More tests for Amazon
  • HDFS

    • Run all tests with hdfs (http + naitive)
    • Reconfigure Travis, add job (probably with hdfs docker)
  • HTTP

    • Run http tests with real server
    • Re-configure Travis

Regression

  • Write regression tests (for all stuff)
    • HDFS
    • S3
    • HTTP
  • Store result always (need for investigation), probably on amazon / any cloud storage
  • Auxiliary stuff (plot graphic, etc)

Gensim tests

  • Go through gensim tests (probably corpora), look to use-cases, add more tests for smart_open

@menshikh-iv
Copy link
Contributor Author

menshikh-iv commented Apr 15, 2018

@mpenkov mpenkov assigned mpenkov and unassigned menshikh-iv Sep 28, 2019
@mpenkov mpenkov added the housekeeping issues for the smart_open team to deal with internally label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
housekeeping issues for the smart_open team to deal with internally
Projects
None yet
Development

No branches or pull requests

2 participants