Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tooling for repository #216

Closed
5 tasks done
menshikh-iv opened this issue Aug 7, 2018 · 2 comments · Fixed by #439
Closed
5 tasks done

Improve tooling for repository #216

menshikh-iv opened this issue Aug 7, 2018 · 2 comments · Fixed by #439

Comments

@menshikh-iv
Copy link
Contributor

menshikh-iv commented Aug 7, 2018

We need to improve the tooling of the repository to increase code-quality and simplify test process

  • Add style-checker (pycodestyle, flake8, any)
  • Add tox that should allow
    • Run tests with all python version
    • Run style-checkers
    • (optional) Run integration tests

Discussion: @piskvorky @mpenkov wdyt to add automatic code-formatter like https://github.com/google/yapf or https://github.com/ambv/black, I want to drop all discussions about code-style at all (honestly, I want to do it for Gensim, but smart_open are good candidate for test this approach, because it simple and small).

Why I think this is useful:

  • auto code-formatting (no need to remember about style always)
  • no comments about code-formatting
  • always clean code
@piskvorky
Copy link
Owner

piskvorky commented Aug 7, 2018

Fine with me of course, good idea. As long as we can enforce, or at least allow, hanging indent (not vertical) and lines longer than 80 chars.

@mpenkov
Copy link
Collaborator

mpenkov commented Aug 8, 2018

I, for one, enjoy flame wars about code style :)

But let's give it a try. If it makes our lives easier, and the code better, then that can't be a bad thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants