Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read files with '?' character in the path when using google storage #458

Closed
chakruperitus opened this issue Apr 4, 2020 · 0 comments · Fixed by #460
Closed

Cannot read files with '?' character in the path when using google storage #458

chakruperitus opened this issue Apr 4, 2020 · 0 comments · Fixed by #460

Comments

@chakruperitus
Copy link
Contributor

chakruperitus commented Apr 4, 2020 •
edited
Loading

Problem description

Cannot open files from google storage when the file path has '?' character in it (which are legal in google storage).

This was addressed for s3 in #285 via PR #291
The same fix is needed for Google Storage as well.

Versions

Please provide the output of:

Linux-4.19.102+-x86_64-with-debian-9.11
Python 3.6.10 (default, Jan  4 2020, 03:29:08)
[GCC 6.3.0 20170516]
smart_open 1.10.0
@chakruperitus chakruperitus changed the title Cannot read files with '?' characters in the path when using google storage Cannot read files with '?' character in the path when using google storage Apr 4, 2020
@chakruperitus chakruperitus mentioned this issue Apr 4, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly handle GCS paths that contain '?' char chakruperitus/smart_open
1 participant
@chakruperitus