Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulnerable to SQL Injection Attacks #175

Open
rharder opened this issue Aug 27, 2024 · 2 comments
Open

Vulnerable to SQL Injection Attacks #175

rharder opened this issue Aug 27, 2024 · 2 comments

Comments

@rharder
Copy link

rharder commented Aug 27, 2024

Our Fortify scans alerted us to possible SQL injection attacks in sqldict.py, and upon inspection it does appear to have a number of SQL statements built with Python's string-building %s feature rather than sqlite's parameterized queries.

Is that something that can be fixed? It's giving our cyber team fits. =)

-Rob

@MattGPT-ai
Copy link

Any update on this? Our CVE is expiring soon, is there even any discussion about how this could possibly be fixed?

@rharder
Copy link
Author

rharder commented Oct 11, 2024

I’m trying to remember what we decided. I think that the places where there are not parameterized queries are only function calls that a developer would make with this or that string as an argument — and the developer already has complete control anyway.

So there’s little chance of “user supplied data” ending up in those function calls.

We moved on and approved the code for our use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants