Skip to content

Commit

Permalink
feat(typography): Headers now have a smaller line-height
Browse files Browse the repository at this point in the history
Additional padding on headers makes up for this difference for
single-line headers.

[Finishes #98157918]
BREAKING CHANGE: (style) header line height and padding changed
  • Loading branch information
Caroline Taymor and Matt Royal authored and Caroline Taymor and Ryan Dy committed Jul 14, 2015
1 parent 26f1de8 commit 492247a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/pivotal-ui/components/pui-variables.scss
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,7 @@ $font-weight-em-max: 900;

$headings-font-family: null;
$headings-font-weight: 400 !default;
$headings-line-height: 1.5 !default;
$headings-line-height: 1.286 !default;
$headings-color: null;

//TODO: create a mixin that will determine multiplers based on px-size
Expand Down
6 changes: 6 additions & 0 deletions src/pivotal-ui/components/typography/typography.scss
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,12 @@ If it's not a heading but you need similar visual treatment you can add just the
// Override the bootstrap margins to use our margin classes so we can align
// things. This is necessary because we have to keep the whitespace margins in sync with this

h1, h2, h3, h4, h5, h6,
.h1, .h2, .h3, .h4, .h5, .h6 {
padding-top: 0.107em;
padding-bottom: 0.107em;
}

h1, .h1, h2, .h2, h3, .h3 {
margin-top: $whitespace-xl;
margin-bottom: $whitespace-l;
Expand Down

0 comments on commit 492247a

Please sign in to comment.