Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetCustomVariable - Invalid result for Visit and Event scoped custom variables #37

Closed
julienmoumne opened this issue Jan 15, 2017 · 0 comments · Fixed by #40
Closed
Labels
Milestone

Comments

@julienmoumne
Copy link
Member

Discovered by @ptr1120 in #36

Querying for an Event scoped custom variable results in an exception.

Querying for a Visit scoped custom variable attempts to return an equivalently named Event scoped custom variable.

The only valid case is querying for a Page scoped custom variable.

The bug was introduced here caba042#diff-3ef10527762c9550c23f3f369808ffa6R290

The test should not be negated as in https://github.com/piwik/piwik-php-tracker/blob/master/PiwikTracker.php#L294

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant