Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused "data" request parameter #38

Closed
julienmoumne opened this issue Jan 15, 2017 · 2 comments
Closed

Remove unused "data" request parameter #38

julienmoumne opened this issue Jan 15, 2017 · 2 comments
Labels
enhancement
Milestone
3.0.0

Comments

@julienmoumne
Copy link
Member

Mentioned by @ptr1120 in #36.

We should provide a way to set the value.
@julienmoumne julienmoumne added this to the v3.0.0 milestone Jan 15, 2017
@julienmoumne julienmoumne mentioned this issue Jan 15, 2017
Merged
@mattab
Copy link
Member

mattab commented Jan 15, 2017

As you have already implemented setCustomTrackingParameter in the C# sdk, it should be possible to use this method to define a custom data parameter. Since data is not a supported tracking api parameter, maybe this is not really needed?

@julienmoumne julienmoumne changed the title Ability to provide custom data (&data=) to the tracking request Deprecate "data" request parameter Jan 16, 2017
@julienmoumne julienmoumne changed the title Deprecate "data" request parameter Remove unused "data" request parameter May 8, 2017
@julienmoumne
Copy link
Member Author

Fixed in 642061f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
2 participants
@mattab @julienmoumne