Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests on Windows: use normalizer for paths #30

Open
bastibuck opened this issue Jun 3, 2018 · 1 comment
Open

Tests on Windows: use normalizer for paths #30

bastibuck opened this issue Jun 3, 2018 · 1 comment

Comments

@bastibuck
Copy link
Contributor

Running the tests (or deploy which includes testing) on windows fails due to different path separators.

image

Also other tests fail on windows. I think most of them are related to path separators. Just copy pasting some test output here:


Error: ENOENT: no such file or directory, scandir 'C:\dev\appstrap_test_testConfig\config.js\presets'

List of tests throwing this error:

  • Presets › Appstrap.reset effects › active presets are removed
  • Presets › Appstrap.reset effects › active preset groups are reset
  • Presets › Appstrap.reset effects › preloaded presets are not removed

Error: Unable to load preset file at undefined

List of tests throwing this error:

  • Presets › single preset (using loadPreset) › active preset merges onto base response payload
  • Presets › single preset (using loadPreset) › active preset replaces base response payload
  • Presets › single preset (using loadPreset) › deactivating preset returns base response payload
  • Presets › preset composition (using loadPresets) › activating presets with modes of merge <- merge <- merge combine appropriately on base
    -Presets › preset composition (using loadPresets) › activating presets with modes of merge <- replace <- merge result in replace <- merge
  • Presets › preset composition (using loadPresets) › activating presets with modes of merge <- merge <- replace result in replace only
  • Presets › Preset management via node api › activating a preset updates endpoint behavior as expected
@moffatethan
Copy link
Contributor

I believe you fix this in #31 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants