Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR (suggestion): open appstrap and interface in browser on invokeFromCLI #38

Open
bastibuck opened this issue Jun 22, 2018 · 3 comments

Comments

@bastibuck
Copy link
Contributor

Just like when you start react dev server via npm run start we could open localhost:5000 and/or appstrap.localhost:5000 in a new tab in the browser.

What do you think?

@pixelprodev
Copy link
Owner

pixelprodev commented Jun 22, 2018

mm i thought about it, but it felt a lil presumptuous. Also, compatibility between operating systems prob adds a complication I didn't want to go down. I know you can call something along the lines of open http://some-website and it work on mac.. dunno if thats the case for windows etc.

@bastibuck
Copy link
Contributor Author

React uses something like
const openBrowser = require('react-dev-utils/openBrowser'); and openBrowser(urls.localUrlForBrowser);
in here which works fine on windows.

Feel like we could just pull this in as a dependency and use this as well as it adds fallback and options to not open the browser etc. Maybe take a look at what it does here.

If you want I could give it a shot.

@pixelprodev
Copy link
Owner

@bastibuck i have a refactor branch in the works right now where this is enabled by default. release coming soon. https://github.com/pixelprodotco/appstrap/tree/refactor/simplify

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants