Standardize modal hide/show logic to support transition animations #3418

twschiller · 2022-05-17T02:08:31Z

Context

ConfirmationModal fadeout animation missing #2246 (comment)
Modifying these will require some verification - by moving the flag to the show property, the we might hit null pointer errors if the code was guarding against raw/unitialized state

The text was updated successfully, but these errors were encountered:

github-actions · 2023-12-30T00:14:05Z

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

github-actions · 2024-04-05T00:14:30Z

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

github-actions · 2024-04-13T00:12:53Z

This issue was closed because it has been stale for 7 days with no activity.

twschiller added the user experience Improve the user experience (UX) label May 17, 2022

twschiller mentioned this issue May 17, 2022

ConfirmationModal fadeout animation missing #2246

Closed

fregante mentioned this issue Sep 1, 2022

Extract brick selector from BrickModal #4212

Closed

fregante mentioned this issue Jan 1, 2023

Refactor Modals not to call hooks when they are not visible #4854

Closed

github-actions bot added the Stale label Dec 30, 2023

fregante removed the Stale label Jan 5, 2024

github-actions bot added the Stale label Apr 5, 2024

fregante mentioned this issue Apr 7, 2024

Figure out ergonomics of CSS modules in ShadowDOM components #7670

Closed

github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2024

Provide feedback