Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX: Simplify the UserData type, and cleanup other types in src/auth/authTypes.ts #7757

Closed
BLoe opened this issue Feb 28, 2024 · 2 comments
Closed

Comments

@BLoe
Copy link
Contributor

BLoe commented Feb 28, 2024

  • This change means that we can now simplify the UserData type, it doesn't need to use Partial everywhere anymore, since we're no longer handling the "anonymous user" situation with the /api/me endpoint returning "empty" user data.
  • This simplification can be propagated into the user data storage/update logic
  • We should separate the types better between user info that can be updated, versus not, and we can get rid of this crazy type: type UserDataUpdate = Required<Except<UserData, "hostname" | "user">>;
  • Clean up/fix the type weirdness around OrganizationAuthState and AuthUserOrganization
Copy link

This issue will be closed in 7 days unless the stale label is removed, or a comment is added to the issue.

@github-actions github-actions bot added the Stale label May 30, 2024
Copy link

github-actions bot commented Jun 7, 2024

This issue was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants