Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependecy las #8

Open
oyhj1801 opened this issue Nov 29, 2024 · 3 comments
Open

Update dependecy las #8

oyhj1801 opened this issue Nov 29, 2024 · 3 comments

Comments

@oyhj1801
Copy link

Hi

Thanks for making this awsome crate!
I tried implementing support for copc in my project, but got issues because I'm using a newer version of the las crate (0.9.1).
Would it be possible to update that dependency in this crate?

Thanks

@oyhj1801
Copy link
Author

oyhj1801 commented Dec 2, 2024

I've forked the repo, updated the dependencies and simplified it to my use case (got rid of the viewer as well as using the structs defined in the las crate for header, bounds and vlr)

Might give a try to implementing a writer

Again thanks for your work

@pka
Copy link
Owner

pka commented Dec 2, 2024

I'm glad that copc-rs is useful for you!

I'm fine with a fork, but I would be also glad to merge PR's or give you direct commit permissions. The viewer is a POC only, so we could move it into a branch or a separate repo.

@oyhj1801
Copy link
Author

oyhj1801 commented Dec 2, 2024

Hi!

The viewer is cool but I feel like it belongs in its own repo.
I can file a PR, but I should probably not commit directly. You should definitely have a look an see if you're comfortable with the changes before merging. I've made some non-precompatible changes so the version number should be bumped to 1.0.0 if you want to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants