Skip to content

Latest commit

 

History

History
639 lines (439 loc) · 18.6 KB

cran-comments.md

File metadata and controls

639 lines (439 loc) · 18.6 KB
Raw

MODIStsp 2.1.0

Test environments

  • [local installation] Windows 11, 64 bit, R 4.3.1: There were no ERRORs, WARNINGs nor NOTEs.
  • [local installation] Ubuntu 22.04.2, 64 bit, R 4.3.1: There were no ERRORs, WARNINGs nor NOTEs.
  • [macbuilder] macOS 13.3.1 (Mac mini Apple M1), 64 bit, R 4.3.0 (https://mac.r-project.org/macbuilder/results/1697113984-3ae0262894333719/): There were no ERRORs, WARNINGs nor NOTEs.
  • [devtools] check_win_devel() (https://win-builder.r-project.org/45728aRz9fCi/): There were no ERRORs, WARNINGs nor NOTEs.
  • [devtools] check_win_release() (https://win-builder.r-project.org/CL1cql0on9q7/): There were no ERRORs, WARNINGs nor NOTEs.
  • [devtools] check_win_oldrelease() (https://win-builder.r-project.org/88js3Seeh0k9/): There were no ERRORs, WARNINGs nor NOTEs.

MODIStsp 2.0.10

Test environments

  • [local installation] Windows 11, 64 bit, R 4.3.0: There were no ERRORs, WARNINGs nor NOTEs.
  • [local installation] Ubuntu 22.04.2, 64 bit, R 4.3.0: There were no ERRORs, WARNINGs nor NOTEs.
  • [macbuilder] macOS 13.3.1 (Mac mini Apple M1), 64 bit, R 4.3.0 (https://mac.r-project.org/macbuilder/results/1686556731-83724b077df2cb09/): There were no ERRORs, WARNINGs nor NOTEs.
  • [devtools] check_win_devel() (https://win-builder.r-project.org/S2szRfR9q3iP/): There were no ERRORs nor WARNINGs (1 NOTE, see below).
  • [devtools] check_win_release() (https://win-builder.r-project.org/1juWeHpUoGjQ/): There were no ERRORs nor WARNINGs (1 NOTE, see below).
  • [devtools] check_win_oldrelease() (https://win-builder.r-project.org/X3tJSYIEHYX9/): There were no ERRORs nor WARNINGs (1 NOTE, see below).

check_win_oldrelease(), check_win_release() and check_win_devel() return the following NOTE:

* checking CRAN incoming feasibility ... [50s] NOTE
Maintainer: 'Luigi Ranghetti <rpackages.ranghetti@gmail.com>'

New maintainer:
  Luigi Ranghetti <rpackages.ranghetti@gmail.com>
Old maintainer(s):
  Luigi Ranghetti <luigi@ranghetti.info>

The email was changed in order to use an account which does not forward to Google, so to respect CRAN requirements.

Moreover, old checks contained the following note:

   Package CITATION file contains call(s) to old-style citEntry().  Please
   use bibentry() instead.

This was fixed in commit 1180ceeaf2a853bfe95cfb0be65804a279ef5d3f.

MODIStsp 2.0.9

  • Windows 11 on local install, R 4.2.1
  • ArchLinux on local install, R 4.2.1
  • win-builder (R-devel, R-release, R-oldrelease)

R CMD check results

There were no ERRORs nor WARNINGs.

check_win_oldrelease() returns the following NOTE:

Possibly mis-spelled words in DESCRIPTION:
  Busetto (40:5)
  HDF (29:24)
  MODIS (2:35, 25:10, 29:18, 30:60, 38:18)
  Ranghetti (40:17)
  mosaicking (26:43)
  rasters (24:63)
  reflectance (31:50, 32:65)
  reprojecting (26:55)
  resizing (26:72)

All these words are correctly spelled, and they do not contain package names nor book titles, so they should not be quoted.

MODIStsp 2.0.8

  • Windows 10 on local install, R 4.1.3
  • ArchLinux on local install, R 4.1.3
  • win-builder (R-devel, R-release, R-oldrelease)

R CMD check results

There were no ERRORs, WARNINGs nor NOTEs.

This submission fixes the following CRAN NOTEs:

Version: 2.0.7
Check: installed package size
Result: NOTE
     installed size is 5.1Mb
     sub-directories of 1Mb or more:
     ExtData 1.9Mb
     app 1.3Mb
     testdata 1.0Mb
Flavors: r-devel-linux-x86_64-fedora-clang, r-devel-macos-arm64, r-devel-macos-x86_64, r-release-macos-arm64, r-release-macos-x86_64, r-oldrel-macos-x86_64

Package size was reduced using zip archives and resizing the logo.

Moreover, the following error appeared as additional donttest issue:

Error in gdal_utils("buildvrt", gdalfile, output.vrt, opts) : 
  gdal_utils buildvrt: an error occured
Calls: MODIStsp ... MODIStsp_process_bands -> <Anonymous> -> gdal_utils
Execution halted

This occurs when the local GDAL environment does not support HDF4 format, which is required by the package. This requirement was now explicitly assessed both in the package description than in the vignette documentation. If the user tries to run functions while HDF4 is not supported, the code exits gracefully informing that "Your current GDAL environment does not support HDF4 file format. Please recompile GDAL including HDF4 drivers.".

MODIStsp 2.0.7

  • Windows 10 on local install, R 4.1.3
  • ArchLinux on local install, R 4.1.3
  • win-builder (R-devel, R-release, R-oldrelease)

R CMD check results

There were no ERRORs, WARNINGs nor NOTEs.

MODIStsp 2.0.6

  • Windows 10 on local install, R 4.1.0
  • ArchLinux on local install, R 4.1.0
  • win-builder (R-devel, R-release, R-oldrelease)

R CMD check results

There were no ERRORs, WARNINGs nor NOTEs.

MODIStsp 2.0.5

  • Windows 10 on local install, R 4.0.3
  • Ubuntu 18.04 on local install, R 4.0.3
  • ArchLinux on local install, R 4.0.3
  • win-builder (R-devel, R-release, R-oldrelease)

This submission should fix errors on Debian builds, due to improper trigger of an helper function leading to writing in the user's lib folder.

Also fixes a couple of bugs.

R CMD check results

There were no ERRORs nor WARNINGs.

NOTE:

* checking CRAN incoming feasibility ... NOTE
Maintainer: 'Luigi Ranghetti <luigi@ranghetti.info>'

New submission

Package was archived on CRAN

Unfortunately Lorenzo Busetto, who maintained the package, suddently passed away (https://docs.ropensci.org/MODIStsp/articles/lorenzo). After that, package was automatically archived for policy violation, since communications sent to him were not read. I now started maintaining MODIStsp (I already authored parts of code).

CRAN repository db overrides:
  X-CRAN-Comment: Archived on 2020-10-31 for policy violation.

  Attempts writing to the user library.

In this submission I fixed a possible tentative of writing in the user library (commit ebdfa2a6ebbadf1ab42bc4679b48d2224ddf333f).

Possibly mis-spelled words in DESCRIPTION:
  Busetto (40:5)
  HDF (29:24)
  MODIS (2:35, 25:10, 29:18, 30:60, 38:18)
  Ranghetti (40:17)
  mosaicking (26:43)
  rasters (24:63)
  reflectance (31:50, 32:65)
  reprojecting (26:55)
  resizing (26:72)

All these words are correctly spelled.

CRAN resubmission review

Please find below the answers to the CRAN reviewer.

Please reduce the length of the title to less than 65 characters.

The title was changed from "A Tool for Automating Download and Preprocessing of MODIS Land Products Data" to "Find, Download and Process MODIS Land Products".

Please only capitalize sentence beginnings and names in the description text. e.g. Quality Indicators --> quality indicators Spectral Indexes --> spectral indexes Surface Reflectance --> surface reflectance

All capitalized letters were changed (unless sentence beginnings).

Please change: products , --> products,

Done.

Please provide a link to the used webservices to the description field of your DESCRIPTION file in the form http:... or https:... with angle brackets for auto-linking and no space after 'http:' and 'https:'.

No webservices were used (the MODIStsp Shiny GUI is launched from local PC). I added a reference to the paper which describes MODIStsp: Busetto and Ranghetti (2016) doi:10.1016/j.cageo.2016.08.020

You have examples for unexported functions. Please either omit these examples or export these functions. Used ::: in documentation: man/split_nodata_values.Rd: MODIStsp:::split_nodata_values(c("255", "250,254:255")) man/split_nodata_values.Rd: MODIStsp:::split_nodata_values(c("255", "250,254:255"), take_all = FALSE) man/split_nodata_values.Rd: MODIStsp:::create_nodata_rcl(c("255", "250,254:255"), c("255", "255"))

Examples of unexported functions were removed.

Some code lines in examples are commented out in MODIStsp.Rd.

Please never do that. Ideally find toy examples that can be regularly executed and checked. Lengthy examples (> 5 sec), can be wrapped in \donttest.

Examples were changed following these indications. All lenghy examples were wrapped in \donttest{}. \dontrun{} is no more used.

Please ensure that you do not use more than 2 cores in your examples, vignettes, etc.

Argument parallel was added to functions MODIStsp(), MODIStsp_process()andMODIStsp_process_bands()(the only functions exploiting multicore computation): ifparallel = FALSE, single core is used. All examples and vignettes were edited setting parallel = FALSE` everywhere.

Please always add all authors, contributors and copyright holders in the Authors@R field with the appropriate roles. e.g.: Babak Naimi

Babak Naimi's contribution was added to the DESCRIPTION.

MODIStsp 2.0.5

  • Windows 10 on local install, R 4.0
  • Ubuntu 18.04 on local install, R 3.6.3
  • win-builder (R-devel, R-release)

R CMD check results

There were no ERRORs, WARNINGs and NOTES

MODIStsp 2.0.4

  • Windows 10 on local install, R 4.0
  • Ubuntu 18.04 on local install, R 3.6.3
  • win-builder (R-devel, R-release)

R CMD check results

There were no ERRORs, WARNINGs

There is one note related to nuw submission (package was archived before I had time to fix it)

This submission should fix errors due to trying accessing temporarily non available urls when building vignettes, which led to CRAN archival. Sorry for that.

Also limits number of retries on HTTR GET to 5 (previously 20) as suggested by DR Riply in his mail

MODIStsp 2.0.3

  • Windows 10 on local install, R 4.0
  • Ubuntu 18.04 on local install, R 3.6.3
  • win-builder (R-devel, R-release)

R CMD check results

There were no ERRORs, WARNINGs and NOTES

This submission should fix errors on Debian builds, due to improper trigger of an helper function leading to writing in the user's lib folder.

Also fixes a couple of bugs.

MODIStsp 2.0.1

  • Windows 10 on local install, R 3.6.3
  • Windows 10 on local install, R 4.0
  • Ubuntu 18.04 on local install, R 4.0
  • win-builder (R-devel, R-release)

R CMD check results

There were no ERRORs, WARNINGs and NOTES

This is a resubmission, fixing notes related to redirected URLS. Sorry for that.

MODIStsp 2.0.0

  • Windows 10 on local install, R 3.6.3
  • Windows 10 on local install, R 4.0
  • Ubuntu 18.04 on local install, R 4.0
  • win-builder (R-devel, R-release)

R CMD check results

There were no ERRORs, WARNINGs

There is a NOTE related to inability to retreive future timestamps. There is a NOTE related to possible invalid urls on some builds, but the url is valid.

MODIStsp 1.4.0

Test environments

  • Windows 10 on local install, R 3.6.3
  • Windows 10 on local install, R 4.0
  • Ubuntu 16.04 on travis-ci (devel and release)
  • win-builder (R-devel, R-release)

R CMD check results

There were no ERRORs, WARNINGs

There is a NOTE related to suggesting a orphaned package (gWidgets) I received a mail from Prof. Ripley about that recently. As suggested, I temporarily moved gWidgets to suggests and use it conditionally for the time being, with the intention of removing the dependency in the next MODIstsp release by switching to a Shiny-based GUI.

Note on installation on macos

Build on macos currently fails (also for MODIStsp 1.3.8) with error

"ERROR Package required but not available: ‘gWidgetsRGtk2’"

due to erroring in build of package "RGtk2".

MODIStsp can be however installed by installing RGtk2 beforehand, following instructions reported here:

http://lbusett.github.io/MODIStsp/articles/installation.html#installing-on-mac

MODIStsp 1.3.9

Test environments

  • ubuntu 18.04 on local install, R 3.6.0
  • ubuntu 14.04 on travis-ci (devel and release)
  • win-builder (R-devel, R-release)
  • windows 10 on local install, R 3.6.0

R CMD check results

There were no ERRORs, WARNINGs or NOTEs

Note on installation on macos

Build on macos currently fails (also for MODIStsp 1.3.8) with error

"ERROR Package required but not available: ‘gWidgetsRGtk2’"

due to erroring in build of package "RGtk2".

MODIStsp can be however installed by installing RGtk2 beforehand, following instructions reported here:

http://lbusett.github.io/MODIStsp/articles/installation.html#installing-on-mac

Test environments

  • ubuntu 18.04 on local install, R 3.5.2
  • ubuntu 14.04 on travis-ci
  • win-builder (R-devel, R-release)
  • windows 10 on local install, R 3.5.2

R CMD check results

There were no ERRORs, WARNINGs or NOTEs

Note on installation on macos

Build on macos currently fails (also for MODIStsp 1.3.3.1) with error

"ERROR Package required but not available: ‘gWidgetsRGtk2’"

due to erroring in build of package "RGtk2".

MODIStsp can be however installed by installing RGtk2 beforehand, following instructions reported here:

http://lbusett.github.io/MODIStsp/articles/installation.html#installing-on-mac

MODIStsp 1.3.7

Test environments

R CMD check results

There were no ERRORs, WARNINGs or NOTEs

Note on installation on macos

Build on macos currently fails (also for MODIStsp 1.3.3.1) with error

"ERROR Package required but not available: ‘gWidgetsRGtk2’"

due to erroring in build of package "RGtk2".

MODIStsp can be however installed by installing RGtk2 beforehand, following instructions reported here:

http://lbusett.github.io/MODIStsp/articles/installation.html#installing-on-mac

MODIStsp 1.3.6

Maintenance release to solve CRAN build errors on debian, due to the test_resetindexes test (I'm sorry I missed this in the previous resubmission). The test is now skipped on CRAN. Additionally, the MODIStsp_resetindexes function was modified to require explicit permission by the user to write on the MODIStsp_previous.json file

Test environments

R CMD check results

There were no ERRORs, WARNINGs or NOTEs

MODIStsp 1.3.5

Maintenance release to solve CRAN build errors on debian, due to the test_addindex test. The test is now skipped on CRAN. Additionally, the MODIStsp_addindex function was modified to require explicit permission by the user to write on the MODIStsp_previous.json file

Test environments

R CMD check results

There were no ERRORs, WARNINGs or NOTEs

MODIStsp 1.3.4

Resubmission

This is a resubmission. In this version I have:

  • Re-added package "testthat" in Suggests and removed an unnecessary call to
    library(testthat) to avoid the following WARNING on Debian:

    "* checking for unstated dependencies in ‘tests’ ... WARNING '::' or ':::' import not declared from: ‘testthat’ 'library' or 'require' call not declared from: ‘testthat’"

Test environments

R CMD check results

There were no ERRORs, WARNINGs or NOTEs

Note on installation on macos

Build on macos currently fails (also for MODIStsp 1.3.3.1) with error

"ERROR Package required but not available: ‘gWidgetsRGtk2’"

due to erroring in build of package "RGtk2".

Note that MODIStsp can be however installed by installing RGtk2 beforehand, following instructions reported here:

http://lbusett.github.io/MODIStsp/articles/installation.html#installing-on-mac

MODIStsp 1.3.3.1

re-submission of v 1.3.3 patching an issue related to missing import of gWidgetsRGtk2, leading to NOTES on Solaris, Fedora and OSX builds (see this thread on r-package-devel for details: https://stat.ethz.ch/pipermail/r-package-devel/2017q3/001790.html)

There were no ERRORs or WARNING. There was 1 NOTE:

  • checking CRAN incoming feasibility ... NOTE Maintainer: 'Lorenzo Busetto lbusett@gmail.com'

Days since last update: 4

due to close resubmission. Sorry for this.

For comments on build environments etc. see the notes below concerning v 1.3.3.

MODIStsp 1.3.3

Test environments

R CMD check results

There were no ERRORs, WARNINGs or NOTEs

Downstream dependencies

This package has no downstream dependencies.

MODIStsp 1.3.2

Test environments

  • ubuntu 16.10 on local install, R 3.3.3
  • ubuntu 14.04 on travis-ci, R 3.3.3 (https://travis-ci.org/lbusett/MODIStsp/builds/222347443)
  • win-builder (R-devel)
  • windows 10 on local install, R 3.3.3 (R CMD check passes if GTK+ library is properly installed and on Windows PATH, otherwise the check causes an endless GTK+ installation loop. This seems a common behaviour for packages relying on gWidgetsRGtk2)
  • local OS X install, R 3.3.3

R CMD check results

There were no ERRORs, WARNINGs

There was 1 NOTE, related to the fact that this is a first submission.

There was a warning in win_builder about the following (possibly) invalid URL:

https://notehub.org/fctdn

I checked it, and it's working.

Downstream dependencies

This package has no downstream dependencies.