This repository has been archived by the owner on Dec 1, 2021. It is now read-only.
Add json.Marshaler support to the Frame type. #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puellanivis
reviewed
Jan 28, 2019
puellanivis
reviewed
Jan 28, 2019
|
@puellanivis See updates. I left the json.Marshaler tests in tact, but maybe that can be removed as tacitly correct. |
|
Looks good from my end. |
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #196
This PR adds
json.Marshalersupport for theFrametype, to facilitate logging of stack traces in JSON format. The output format is equivalent tofmt.Printf("v+%"), but without newlines or tab characters.To me, this format seems the most generally useful, but an argument could be made for outputting a JSON object instead (i.e.
{"file":"...", "line": XX, "name": "..."}.).