server: use os.IsNotExist to map sshFxNoSuchFile #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always use os.IsNotExist to identify any OS specific error types that represent missing files or directories. This resolves an issue on Windows where some system errors (ENOTDIR) were not being identified as 'not found' errors and mapped to sshFxNoSuchFile. fixes #381
willnorris
added a commit
to willnorris/perkeep
that referenced
this pull request
Sep 14, 2020
update github.com/bradfitz/latlong in order to pick up bradfitz/latlong@afb97c1f9 which updates the import path of freetype-go. The old path no longer exists and was causing problems with go mod. update github.com/pkg/sftp for pkg/sftp#382 which resolves CI test failures for Windows.
willnorris
added a commit
to willnorris/perkeep
that referenced
this pull request
Sep 14, 2020
update github.com/bradfitz/latlong in order to pick up bradfitz/latlong@afb97c1f9 which updates the import path of freetype-go. The old path no longer exists and was causing problems with go mod. update github.com/pkg/sftp for pkg/sftp#382 which resolves CI test failures for Windows.
puellanivis
reviewed
Sep 14, 2020
Return early from statusFromError if os.IsNotExist is true.
|
technically, this means we could also remove the |
|
Up to you, if you want to remove the ENOENT case. Like you say, we should never hit it anymore. But I am going to guess that it’s not actually too much code or binary bloat, so it might be better to keep it around as a just in case backup? 🤷♀️ I’m fine either way. |
|
yeah, I think probably leave it in. 👍 Given what the function is doing... mapping syscall error numbers to ssh error codes, it makes sense for it to have fuller coverage of different error numbers. That keeps it somewhat semantically independent of the statusFromError func. |
willnorris
added a commit
to willnorris/perkeep
that referenced
this pull request
Sep 15, 2020
update github.com/bradfitz/latlong in order to include bradfitz/latlong@afb97c1f9 which updates the import path of freetype-go. The old path no longer exists and was causing problems with go mod. update github.com/pkg/sftp to include pkg/sftp#382 which resolves CI test failures for Windows.
willnorris
added a commit
to willnorris/perkeep
that referenced
this pull request
Sep 15, 2020
update github.com/bradfitz/latlong in order to include bradfitz/latlong@afb97c1f9 which updates the import path of freetype-go. The old path no longer exists and was causing problems with go mod. update github.com/pkg/sftp to include pkg/sftp#382 which resolves CI test failures for Windows.
willnorris
added a commit
to willnorris/perkeep
that referenced
this pull request
Sep 23, 2020
update github.com/bradfitz/latlong in order to include bradfitz/latlong@afb97c1f9 which updates the import path of freetype-go. The old path no longer exists and was causing problems with go mod. update github.com/pkg/sftp to include pkg/sftp#382 which resolves CI test failures for Windows.
willnorris
added a commit
to willnorris/perkeep
that referenced
this pull request
Sep 24, 2020
update github.com/bradfitz/latlong in order to include bradfitz/latlong@afb97c1f9 which updates the import path of freetype-go. The old path no longer exists and was causing problems with go mod. update github.com/pkg/sftp to include pkg/sftp#382 which resolves CI test failures for Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use os.IsNotExist to identify any OS specific error types that represent missing files or directories. This resolves an issue on Windows where some system errors (ENOTDIR) were not being identified as 'not found' errors and mapped to sshFxNoSuchFile.
fixes #381