-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New Check]: Increase upper constraint with no revision bump #673
Comments
From my knowledge, and multiple tests I just did, it reports a RdependChanged warning. Do note that this is ran during Can you verify it also is raised for you? |
I must have something misconfigured, because I'm getting:
Note that I renamed After renaming the remote back to
Just to be clear, I get this same output when the change is staged and when it is committed as well. Ultimately, I would like to elevate this warning to an error in the pkgcheck-action for the gentoo-haskell repo. Are there any instructions on how to do this? |
So first of all, before I continue to analyze and debug other stuff, just know that you can continue using your remote name, just configure [haskell]
git-remote = gentoo-haskell |
Checked again your example:
I see you are changing DEPEND and not RDEPEND. This check is for RDEPEND. From my knowledge, changing build time stuff doesn't need revbump always (there are rules for when yes and when no, but this can't be checked by pkgcheck). For RDEPEND the answer is always yes. |
I've heard conflicting versions of this line of thinking myself. Perhaps @thesamesam can chime in on this. Edit: I think that the scenario I presented (an upper bound in DEPEND was changed) always needs a revbump. If there are any exceptions to this, I will gladly close this issue. |
Is there an existing such new check request for this?
Explain
The scenario:
Examples
gentoo-haskell/gentoo-haskell@37a3672
Result:
A revision bump from
dev-haskell/unicode-data-0.4.0.1
todev-haskell/unicode-data-0.4.0.1-r1
fixes this.Note that the changes in
DEPEND
forghc
andcabal
do not cause a problem here because they are increasing the lower version bound of dependencies; portage is already trying to upgrade these packages to the highest possible version, so increasing the lower bound will not prevent portage from upgrading these.Output message
'<dev-haskell/hspec-2.11' changed to '<dev-haskell/hspec-2.12' with no version/revision bump
Documentation
Warn when an upper version bound is changed, but the package has not received a revision bump nor upgraded its version number.
Result level
warning
The text was updated successfully, but these errors were encountered: