Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-venv.sh script doesn't work with multiple sub directories #26

Open
mfts opened this issue Mar 3, 2023 · 7 comments
Open

python-venv.sh script doesn't work with multiple sub directories #26

mfts opened this issue Mar 3, 2023 · 7 comments

Comments

@mfts
Copy link
Contributor

mfts commented Mar 3, 2023

I'm packging azure-cli and ran into the issue that they have different subdirectories here: https://github.com/Azure/azure-cli/tree/dev/src

@mxcl
Copy link
Member

mxcl commented Jan 7, 2024

The new bkpyvenv supports this to some extent. Hard to be sure though since I'm not sure from the report if the issue is that two virtual-environments are needed or if multiple commands need to be provided.

@magnusviri
Copy link
Contributor

I don't know if this is related but I ran into an issue with a project named jctl with the error error: Multiple top-level packages discovered in a flat-layout: ['jctl', 'props']. I had to add something to my setup.py file to get around it. https://stackoverflow.com/questions/72294299/multiple-top-level-packages-discovered-in-a-flat-layout

@jhheider
Copy link
Contributor

@magnusviri that sounds like it doesn't like the props directory pkgx makes; if you have no props, considering rmdir props or mv props .props and see if it like that better.

@mxcl
Copy link
Member

mxcl commented Jan 24, 2024

we could probably deprecate props and use the new per array node prop in general since adding files to a build directory is asking for issues like @magnusviri’s

@jhheider
Copy link
Contributor

jhheider commented Jan 24, 2024

it's true; the only argument against it is potential bloat in the yaml reducing legibility. possibly only creating the props directory if needed will give the yaml author the control they need.

inlining long/ugly patches doesn't sound fun.

@mxcl
Copy link
Member

mxcl commented Jan 24, 2024

we could allow the prop: node to take a filename

@jhheider
Copy link
Contributor

jhheider commented Jan 24, 2024

well, if we're brainstorming, we could have an build.script[].install { dest, contents, mode? } key, if we needed to keep it "simple".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants