-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean Up Layout on Package Details View #655
Comments
@tsmitty11 the in-app-terminal pr for SD has been merged, this need to be updated. |
@getneil thanks Neil, I'll update with a new design. |
Here's a Loom video. I think @mxcl intended for the tabs to open the cli and gui respectively, so we can probably omit the 'open in terminal' button... but he can confirm yay or nay. https://www.loom.com/share/978f8e766fd043908d50702b2c9a186e?sid=5fe72fd6-f215-4761-aa4e-b5dd14a77723 Assuming that's the case, here's the install state: And the installed/update state: |
we shouldn't omit the open button it's the major CTA and should be positioned accoringly |
@mxcl thoughts on this? Leaves more horizontal space for the CTA lockup. Also allows a bit flexibility for the description text as it's confined to it's own row here. |
superb. approved |
@getneil @ABevier pushing this to top, as issue was technically closed. See above for details design approved by mxcl. https://www.figma.com/file/UZJ2CrxsoX0pkhEY4NZE5j/GUI-Master?type=design&node-id=749%3A3619&mode=dev |
sorry about that it was linked to a PR. that was merged |
I have a more up-to-date design that takes all of the buttons into consideration and rearranges them into a more appealing layout. Please let @tsmitty11 if you have any questions as it relates to the design.
The text was updated successfully, but these errors were encountered: