Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Hardcode" pkl version somewhere instead of GitHub action input #8

Open
StefMa opened this issue Oct 8, 2024 · 0 comments
Open

"Hardcode" pkl version somewhere instead of GitHub action input #8

StefMa opened this issue Oct 8, 2024 · 0 comments

Comments

@StefMa
Copy link
Contributor

StefMa commented Oct 8, 2024

Right now it is not visible for consumers what pkl version is used when using the pkl-eval node package.
If I get it right, this repo uses GitHub actions input for that.
When doing a release, you can put the pkl version as input and it will does everything on the fly.

I think it makes more sense to "hardcode" somewhere the pkl version that is used for that release so it is more visible ofr consumers.

Alternative:
You use the same version schema as pkl 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant