New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port handling in incoming request #4

Open

jeromeetienne opened this issue Aug 18, 2010 · 1 comment

jeromeetienne commented Aug 18, 2010

in parsing the incoming request, there is a little glitch in the port handling

http://github.com/pkrumins/nodejs-proxy/blob/master/proxy.js#L86

here in fact the port may be in the header 'host'

for reference http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html Host = "Host" ":" host [ ":" port ] ; Section 3.2.2.

Author

jeromeetienne commented Aug 19, 2010

i made a patch to fix it. http://gist.github.com/537719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment