New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateTime is deprecated #446

Open

bdewater opened this issue Nov 2, 2022 · 0 comments

bdewater commented Nov 2, 2022 •

edited

Loading

Deprecated since Ruby 3.0: https://ruby-doc.org/stdlib-3.0.0/libdoc/date/rdoc/DateTime.html, also see the "When should you use DateTime and when should you use Time?" section.

Referenced here: https://github.com/plaid/plaid-ruby/blob/v17.0.0/README.md#dates

Used here:

plaid-ruby/lib/plaid/api_client.rb

Lines 235 to 237 in 6c900a2

    
           when 'DateTime' 
        
             # parse date time (expecting ISO 8601 format) 
        
             DateTime.parse data

Instead of replacing with Time.parse it seems Time.iso8601 would be appropriate here and is more performant.

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment