Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

subtype check in synthesize #3012

Closed
eugene-doobu opened this issue Nov 15, 2024 · 1 comment
Closed

subtype check in synthesize #3012

eugene-doobu opened this issue Nov 15, 2024 · 1 comment
Assignees
@eugene-doobu
Milestone
v260.0.0

Comments

@eugene-doobu
Copy link
Member

eugene-doobu commented Nov 15, 2024 •
edited
Loading

아이템 서브타입 별로 합성 갯수가 다르게 설정합니다

  • 기존의 작성된 synthesize의 테스트에서 더 심화된 테스트 코드를 추가합니다.
  • 여러 아이템을 한번에 생성하는 경우에 대한 케이스를 여러가지 추가합니다
  • 성공 유무를 통해 장비의 grade가 제대로 설정되었는지 체크하는 테스트를 추가합니다.
@eugene-doobu eugene-doobu self-assigned this Nov 15, 2024
@eugene-doobu eugene-doobu added this to the v260.0.0 milestone Nov 15, 2024
@eugene-doobu eugene-doobu moved this from Todo to Review in Nine Chronicles Nov 15, 2024
@eugene-doobu eugene-doobu moved this from Review to In Progress in Nine Chronicles Nov 15, 2024
@eugene-doobu eugene-doobu mentioned this issue Nov 15, 2024
Closed
@eugene-doobu eugene-doobu changed the title synthesize test subbtype check in synthesize Nov 18, 2024
@eugene-doobu eugene-doobu changed the title subbtype check in synthesize subtype check in synthesize Nov 18, 2024
@eugene-doobu
Copy link
Member Author

pr머지 대기가 길어지고 있어 아래 이슈에서 같이 처리하겠습니다
#3008

@github-project-automation github-project-automation bot moved this from Hold to Done in Nine Chronicles Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eugene-doobu eugene-doobu

Labels
None yet
Projects
Nine Chronicles
Archived in project
Milestone
v260.0.0
Development

No branches or pull requests
1 participant
@eugene-doobu