Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draino and kured #81

Open
limberger opened this issue Aug 11, 2020 · 4 comments
Open

draino and kured #81

limberger opened this issue Aug 11, 2020 · 4 comments

Comments

@limberger
Copy link

please, is there any simple way to integrate draino with kured?
On successful drain, touch /var/run/reboot-required ...

Thanks!

@limberger
Copy link
Author

or ... on successful drain, exec a command on the node ...

@jacobstr
Copy link
Contributor

jacobstr commented Aug 29, 2020

Can you walk this out a bit for me? Maybe kured could set a NodeCondition for us and we sit back and relax in the bliss of generality that is NodeConditions :)

@dbenque
Copy link
Contributor

dbenque commented Sep 4, 2020

From kured doc:

Cordons & drains worker nodes before reboot, uncordoning them after

I see that the 2 systems would be competing on the cordon/drain activities. If draino takes the actions to cordon/drain, and then only kured reboots the node, the condition on the node should be removed from the node (if it makes sense, it may not depending on the signal/condition), else the uncordon by kured would be immediately reverted (back to cordon) by Draino.

@limberger
Copy link
Author

I ended up choosing to use only kured with alertmanager and a webhook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants