Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: No bare URIs breaks file links with triple slashes #1030

Closed
2 of 3 tasks
Martin-Milbradt opened this issue Feb 29, 2024 · 3 comments · Fixed by #1032
Closed
2 of 3 tasks

Bug: No bare URIs breaks file links with triple slashes #1030

Martin-Milbradt opened this issue Feb 29, 2024 · 3 comments · Fixed by #1032
Assignees
Labels
bug Something isn't working markdown General Markdown or Markdown related issue or feature reproducible resolution/update-made A change has been made that should resolve this issue or request

Comments

@Martin-Milbradt
Copy link

  • I have verified that I am on the latest version of the Linter

Describe the Bug

A file link with the slashes /// is broken after linting:
E.g. file:///C:/Untitled.md becomes <file:///>C:/Untitled.md

How to Reproduce

Steps to reproduce the behavior:

  1. Activate the rule "No Bare URIs"
  2. Create a note with a file link, e.g. file://C:/Untitled.md
  3. Lint the file

Excerpt from the log

# Untitled

file:///C:/Untitled.md

Running No Bare URLs
no-bare-urls: 0.09999999403953552 ms
# Untitled

<file:///>C:/Untitled.md

Expected Behavior

Brackets are around the link, not after file:///

Expected output:

<file:///C:/Untitled.md>

Screenshots

image

Device

  • Desktop
  • Mobile

Additional Context

Add any other context about the problem here.

@Martin-Milbradt Martin-Milbradt added the bug Something isn't working label Feb 29, 2024
@pjkaufman
Copy link
Collaborator

Hey @Martin-Milbradt . It looks like I can reproduce this. I will see if I can figure out what is going on. It looks like the regex is matching correctly based on the regex tester I am using, but I am getting the result that you are. Hopefully this can be resolved soon.

@pjkaufman pjkaufman added markdown General Markdown or Markdown related issue or feature reproducible labels Feb 29, 2024
@pjkaufman pjkaufman self-assigned this Feb 29, 2024
@pjkaufman
Copy link
Collaborator

Looks like it was a simple fix. I will go ahead and push that up.

@pjkaufman
Copy link
Collaborator

This change has been merged into master and should go out in the next release. Please let us know if it does not work on master or in the next release.

@pjkaufman pjkaufman added the resolution/update-made A change has been made that should resolve this issue or request label Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working markdown General Markdown or Markdown related issue or feature reproducible resolution/update-made A change has been made that should resolve this issue or request
Projects
Archived in project
2 participants