-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: incorrect/spurious transformation être → êtree. #633
Comments
Hey @lebigot , is there a reason not to add that value to the ignore list? English is the only language that the auto fix is really designed for. So for French words that may be the case, but when used in English it may not be the same (assuming that is even a thing). However if that is a French word and the English usage is spelled as you suggest, that should probably be bubbled up to the codespell maintainers to get it fixed there as well. |
I have not heard anything about this. in about 2 weeks. If I do not hear anything else by Sunday, I will close this issue since I am not able to validate the claim here on my own with the information provided. |
There is a reason to not add "être" to the ignore list: there is no valid reason for it to be transformed into "êtree" anyway, be it in French or English, where "êtree" doesn't exist, and obviously fixing this at the source is obviously more useful for everybody. :) Now, codespell 2.2.4 (the latest version) doesn't run into this problem. Maybe the bug comes from a previous version of codespell? Maybe it is somewhere in linter? Maybe it's a wild guess, but maybe linter somehow doesn't recognize the "ê" and codespell (via linter, not called directly through codespell 2.2.4) applies its rule "tre" → "tree", resulting in "être" being transformed into "êtree", which is not correct? |
This may be a bug in the Linter where that rule you suggested may be getting applied. Let me see if it gets modified in a UT and move forward from there. The possibility you suggested could be the case. I wonder if python has a different default set for regex which could cause the issue in question. |
Looks like I have a fix for this. Thanks for taking a look at codespell and verifying it was not in the list @lebigot ! |
The change should go out with the next release. |
Great, thanks! |
Describe the Bug
When a text contains "être", this word is transformed into "êtree", which is incorrect (in French).
How to Reproduce
Steps to reproduce the behavior:
Expected Behavior
The word "être" should instead not be touched.
Device
The text was updated successfully, but these errors were encountered: