doesn't work with atom 1.12 #85

sagiegurari · 2016-10-15T13:54:23Z

I'm using windows 10, configured the package to use git bash as the exectuable and it all worked well for some time.
However with the new atom 1.12 beta it is just opening a new panel but the shell inside is not started.
there are no errors in the console.

sagiegurari · 2016-10-15T15:05:26Z

there is an error when opening the console

task.coffee:86 Cannot find module '..\bin\win32\ia32.m49.node' Error: Cannot find module '..\bin\win32\ia32.m49.node'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous>

Dysp · 2016-10-15T18:23:07Z

+1

rdfedor · 2016-10-18T18:37:09Z

Have the same issue after upgrading to Atom 1.12 on MacOSX,

task.coffee:86 Cannot find module '../bin/darwin/x64.m49.node' Error: Cannot find module '../bin/darwin/x64.m49.node'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)

then after this appears I get this error,

Cannot read property 'bind' of null TypeError: Cannot read property 'bind' of null
    at process.<anonymous> (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/task-bootstrap.js:82:23)
    at emitTwo (events.js:106:13)
    at process.emit (events.js:191:7)
    at process.nextTick (internal/child_process.js:719:12)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

These errors do not appear until after you try opening a new terminal tab.

sagiegurari · 2016-10-18T19:59:29Z

probably need to upgrade nan but I'm not sure if this project is still maintained which is unfortunate.

rdfedor · 2016-10-19T00:31:24Z

Sometimes perfection doesn't need an update lol. Give em some time, coming from a software engineer background myself, I believe this is ran by company so they'll probably need to schedule time for one of their engineers to check it out during one of their next sprints.

alexrussell · 2016-10-20T08:43:47Z

I think this is the same issue I have. On opening a terminal I get a console warning:

Cannot find module '../build/Release/pty.node'

Which it says originates in task.coffee:85 (file:///Users/distiller/atom/out/app/src/task.coffee) - presumably from some build process as my user is not distiller.

That is followed by an error stacktrace:

task.coffee:86 Cannot find module '../bin/darwin/x64.m49.node' Error: Cannot find module '../bin/darwin/x64.m49.node'
    at Function.Module._resolveFilename (module.js:440:15)
    at Function.Module._load (module.js:388:25)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/alexrussell/.atom/packages/platformio-ide-terminal/node_modules/pty.js/lib/pty.js:18:9)
    at Module._compile (module.js:541:32)
    at Object.value [as .js] (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/compile-cache.js:201:21)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/alexrussell/.atom/packages/platformio-ide-terminal/node_modules/pty.js/index.js:2:18)
    at Module._compile (module.js:541:32)
    at Object.value [as .js] (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/compile-cache.js:201:21)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Users/alexrussell/.atom/packages/platformio-ide-terminal/lib/process.coffee:1:7)
    at Object.<anonymous> (/Users/alexrussell/.atom/packages/platformio-ide-terminal/lib/process.coffee:1:1)
    at Module._compile (module.js:541:32)
    at Object.value [as .coffee] (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/compile-cache.js:201:21)
    at Module.load (module.js:458:32)
    at tryModuleLoad (module.js:417:12)
    at Function.Module._load (module.js:409:3)
    at Module.require (module.js:468:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/task-bootstrap.js:110:13)

Which it says originates in task.coffee:86 (file:///Users/distiller/atom/out/app/src/task.coffee)

And then after that another error stacktrace:

Cannot read property 'bind' of null TypeError: Cannot read property 'bind' of null
    at process.<anonymous> (/Applications/Atom Beta.app/Contents/Resources/app.asar/src/task-bootstrap.js:82:23)
    at emitTwo (events.js:106:13)
    at process.emit (events.js:191:7)
    at process.nextTick (internal/child_process.js:719:12)
    at _combinedTickCallback (internal/process/next_tick.js:67:7)
    at process._tickCallback (internal/process/next_tick.js:98:9)

Which it says also originates in task.coffee:86 (file:///Users/distiller/atom/out/app/src/task.coffee)

Screenshot for full console details.

Atom 1.12.0-beta3, OSX 10.11.6.

Is it possible it just failed to build some native module on install (there was no error - popup or console - on install)?

ivankravets · 2016-10-20T14:22:47Z

I see that we will have a tons of problems with new Atom 1.12. They switched to new Electron and other packages that require new NAN and other things. The pty.js depends on obsolate winpty that doesn't work with new nan 2.3.5. I can rebuild all binaries for Unix but need to think what to do with Windows users.

Please don't use Atom 1.12 and wait when we preapre all PTY binaries.

sagiegurari · 2016-10-20T16:12:35Z

Thanks for the update.
v8 upgrade will happen every now and than so it is always best to use latest nan to ensure you are prepared for those upgrades while still supporting older versions.

skull-squadron · 2016-10-30T20:27:18Z

Can't use 1.11 because it breaks some mandatory packages.

EDIT: https://github.com/tjmehta/terminal-plus working on 1.12 beta5

apm i tjmehta/terminal-plus

skull-squadron · 2016-10-30T22:14:45Z

See also jeremyramin#364

Mehul · 2016-11-02T21:26:32Z

Was having the exact same issues with installed versions of stable or beta.

Then I used the stand alone windows exe and installed platformio-ide-terminal package. That seems to work, so far.

kachkaev · 2016-11-06T15:19:57Z

@alexrussell I'm seeing the same error as you on OSX, Atom 1.12-beta7: Cannot find module '../bin/darwin/x64.m49.node'. What did you end up doing as a workaround?

UPD: OK, here's my temporary workaround: 😆

ivankravets · 2016-11-06T15:40:32Z

Wow.... 12 comments... multiple ups ( 👍 )

Need to resovle this issue...

P.S: Is here someone with Ubuntu?

alexrussell · 2016-11-06T15:49:59Z

@kachkaev haha nice workaround :) And no I didn't find anything that I found particularly satisfactory - like you I'm just using separate terminals for now.

@ivankravets from the looks of comments on both this and the original terminal-plus package (as well as other people's forks) it's all about updating the version numbers (commit references) for the dependent packages pty.js and term.js (I think actually just pty.js). But other than that (presumably they need to have native modules built for each platform and something needs tweaking and that's why the updates are required) I don't know much of the root of the issue.

ivankravets · 2016-11-06T15:56:34Z

@alexrussell we have own PlatformIO's fork of PTY with pre-built binaries. It allows to use PlatformIO IDE Terminal on the machine where compiler is not installed for gyp.

Yes, I know that we should update nan dependcy in pty.js but it will break WinPTY. But...!!! We have great news! Daniel Imms (@Tyriar) from @microsoft re-forked PlatformIO's PTY and added support for nan 2.2.1! See https://github.com/Tyriar/pty.js/commits/prebuilt

As result, we've just succesfully compiled PTY.JS for Windows and tested on Windows 8/10 and are working on other binaries for macOS & Linux.

Stay tuned! 😊 Also, don't forget to try http://platformio.org 😆

alexrussell · 2016-11-06T16:09:56Z

A-ha good news.

As for trying PlatformIO, I'd love to play around with and learn new things but I have enough on my plate at the moment! :)

ivankravets · 2016-11-06T16:38:15Z

PlatformIO IDE Terminal 2.2.1 is out!

P.S: Atom 1.12 for Linux is not ready. Please comment here if you are Ubuntu owner and would like to help us.

kachkaev · 2016-11-06T16:56:16Z

Awesome!

(macOS 10.12.1, Atom 1.12-beta 7)

sagiegurari · 2016-11-06T17:21:30Z

works good for me as well. thanks.

Tyriar · 2016-11-06T18:33:25Z

Glad to help 😃 I'm planning on cleaning up the pty.js situation and improving Windows support soon. Follow microsoft/vscode#13625 if you want to track that development.

alexrussell mentioned this issue Oct 20, 2016

no terminal prompt jeremyramin/terminal-plus#359

Open

Fred-Barclay mentioned this issue Oct 30, 2016

Terminal not taking any inputs jeremyramin/terminal-plus#361

Open

ivankravets added the bug label Nov 6, 2016

ivankravets self-assigned this Nov 6, 2016

ivankravets closed this as completed in 05946e7 Nov 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doesn't work with atom 1.12 #85

doesn't work with atom 1.12 #85

sagiegurari commented Oct 15, 2016

sagiegurari commented Oct 15, 2016

Dysp commented Oct 15, 2016

rdfedor commented Oct 18, 2016 •

edited

Loading

sagiegurari commented Oct 18, 2016

rdfedor commented Oct 19, 2016

alexrussell commented Oct 20, 2016

ivankravets commented Oct 20, 2016

sagiegurari commented Oct 20, 2016

skull-squadron commented Oct 30, 2016 •

edited

Loading

skull-squadron commented Oct 30, 2016

Mehul commented Nov 2, 2016 •

edited

Loading

kachkaev commented Nov 6, 2016 •

edited

Loading

ivankravets commented Nov 6, 2016

alexrussell commented Nov 6, 2016

ivankravets commented Nov 6, 2016

alexrussell commented Nov 6, 2016

ivankravets commented Nov 6, 2016

kachkaev commented Nov 6, 2016

sagiegurari commented Nov 6, 2016

Tyriar commented Nov 6, 2016

doesn't work with atom 1.12 #85

doesn't work with atom 1.12 #85

Comments

sagiegurari commented Oct 15, 2016

sagiegurari commented Oct 15, 2016

Dysp commented Oct 15, 2016

rdfedor commented Oct 18, 2016 • edited Loading

sagiegurari commented Oct 18, 2016

rdfedor commented Oct 19, 2016

alexrussell commented Oct 20, 2016

ivankravets commented Oct 20, 2016

sagiegurari commented Oct 20, 2016

skull-squadron commented Oct 30, 2016 • edited Loading

skull-squadron commented Oct 30, 2016

Mehul commented Nov 2, 2016 • edited Loading

kachkaev commented Nov 6, 2016 • edited Loading

ivankravets commented Nov 6, 2016

alexrussell commented Nov 6, 2016

ivankravets commented Nov 6, 2016

alexrussell commented Nov 6, 2016

ivankravets commented Nov 6, 2016

kachkaev commented Nov 6, 2016

sagiegurari commented Nov 6, 2016

Tyriar commented Nov 6, 2016

rdfedor commented Oct 18, 2016 •

edited

Loading

skull-squadron commented Oct 30, 2016 •

edited

Loading

Mehul commented Nov 2, 2016 •

edited

Loading

kachkaev commented Nov 6, 2016 •

edited

Loading