Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell config warning is very noisy #35

Open
pjcdawkins opened this issue Jan 14, 2023 · 2 comments
Open

Shell config warning is very noisy #35

pjcdawkins opened this issue Jan 14, 2023 · 2 comments

Comments

@pjcdawkins
Copy link
Contributor

"checkShellConfigLeftovers" sends a big warning after every command, about config left over in a shell config file, even though it's not doing any harm

also getting rid of this config unfortunately removes the "p" alias

suggestions (any or all):

  • make it softer (not "Warning")
  • suggest to auto-remove the config so there's no unnecessary manual work
  • only show the warning once, or once a week
  • move it to the beginning not the end of the command output (so it's easier to read the desired output)
  • allow the warning to be suppressed with config / an environment variable
@akalipetis
Copy link
Member

  • make it softer (not "Warning")

Would this mean just removing the "Warning:" prefix, or also an update in the wording?

  • suggest to auto-remove the config so there's no unnecessary manual work

We've decided against that, as it might break the local configuration of the user, in case the user has manually altered that part.

  • only show the warning once, or once a week

We could switch to displaying this once every day, I think that's the a good improvement

  • move it to the beginning not the end of the command output (so it's easier to read the desired output)

All non-blocking warnings have been pushed to the end (same happens with the update prompt), to avoid confusing the user before they end their command. Why would moving it to the beginning would help?

  • allow the warning to be suppressed with config / an environment variable

Definitely a good idea as well.

I think we can start with lowering the frequency of the appearance of the message and allowing the user to disable this with a config, what do you think @pjcdawkins @lolautruche?

@lolautruche
Copy link
Contributor

I agree with your suggestion @akalipetis

@akalipetis akalipetis self-assigned this Feb 2, 2023
@akalipetis akalipetis removed their assignment May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants