Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emitters freeze after several seconds when built from latest tools #108

Open
jacobtabak opened this issue May 19, 2020 · 3 comments
Open

Comments

@jacobtabak
Copy link

I cloned the project and tried to run on Android Studio 3.6.3. Some adjustments had to be made to get it to build:

  • Update gradle plugin to com.android.tools.build:gradle:3.6.3
  • Add google() repository to root build.gradle
  • Update gradle to 5.6.4 in gradle-wrapper.properties
  • Remove minSdkVersion from AndroidManifest.xml

First thing I noticed when I got the sample up and running is that the emitters that are supposed to go on indefinitely stop emitting after several seconds. I downloaded the sample from Google Play and it works fine.

Would you mind taking a few minutes trying to build with the latest tools and see if you encounter the same issues?

@jacobtabak jacobtabak changed the title Emitters freeze after several seconds built from latest tools Emitters freeze after several seconds when built from latest tools May 19, 2020
@plattysoft
Copy link
Owner

plattysoft commented May 29, 2020

I haven't touched this project in a long while, if I were to update it I will most like look into better compatibility with Kotlin (like, making sure the interfaces with one method are the last parameter)

If you find different behaviour, try getting the code that was tagged as released, there have been a few minor bugs and tweaks that haven't been into any release, the latest code is not the same as the latest published version.

I might try to take a look. Thanks for the heads up!

@jacobtabak
Copy link
Author

jacobtabak commented Jun 5, 2020

Thank you for your response! You're right, I just changed the project reference in the sample to the latest release and it works now. But there is definitely an issue with the master branch at the time of this comment.

Edit: It still seems to be an issue even using the released version of the library.

@jacobtabak
Copy link
Author

I think the problem is actually related to a leak of some sort. I put a log statement in the timer task in the sample app and each time you start an emitter a new timertask is added and never cleaned up. I'm using Leonids for a "follow touch" emitter, and I don't run into problems if I destroy/clean up the previous particle system when a new down touch is detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants