Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple physics engine #2801

Open
LeXXik opened this issue Jan 30, 2021 · 9 comments
Open

Decouple physics engine #2801

LeXXik opened this issue Jan 30, 2021 · 9 comments
Labels
area: physics Physics related issue feature

Comments

@LeXXik
Copy link
Contributor

LeXXik commented Jan 30, 2021

Currently, Ammo is deeply integrated into rigidbody and collision components, making it an integral part of the PC engine.
I would like to propose decoupling the physics engine into own backend provider.

backends/ammo

There would be no changes to the current components API. However, instead of processing the physics inside the component, a component would call appropriate method of the currently selected backend. For now, it would be Ammo.

For example, when a user does rigidbody.teleport(pos, rot), the component would call backend.teleport(pos, rot). Most of the general purpose physics engines do their simulations through iterating simulation steps, so their features are similar. PC component can abstract away the inner workings of the one or another backend. If some physics engine doesn't support a feature, it is easy for the backend to notify a user.

This makes it trivial to add support and switching to another physics engine:

backends/physx
backends/rapier
backends/...

It also makes it easier for the games to implement and add custom physics engine - it would be simply a matter of adding another backend. All backends could have the same API signature, which would make PC agnostic about which backend is currently handling the physics simulation.

@mvaligursky mvaligursky added area: physics Physics related issue enhancement labels Jan 30, 2021
@mvaligursky
Copy link
Contributor

Agreed, we've discussed this internally as well. Also it'd be good to perhaps investigate an option of running the physics engine on a worker thread as an option.

@willeastcott
Copy link
Contributor

I would love to do this - it's on our roadmap. But it's a big job.

@LeXXik
Copy link
Contributor Author

LeXXik commented Jan 30, 2021

I have some experience placing Ammo and Rapier in a worker. The method has both pros and cons.

The pros are obviously in the non-blocking nature of the parallel thread. For example, in Ammo there was a need to do a 1000 step forward-simulation. This introduces a tiny game freeze, when executed in the main thread, but has no such issues, when running in a worker. In general, though, you don't need to have forward simulations, or can cut them into smaller chunks. As such there is little benefit in a worker otherwise, unless you are fighting for 1-2ms in your frame budget for something else. A higher gain would be in using the backend that supports SIMD operations via Wasm. Even running in main thread.

The cons is that you lose a direct access to the state queries of the simulated bodies. For example, it becomes less trivial to check if the body is sleeping. You have to issue a message to the worker, which will do the query in the physics world and report back - that can easily take multiple frames, not mentioning simulation steps. Since the worker is running in own context, you also have no access to the objects there, so using custom callbacks becomes problematic, but can be solved through serializing a function into a string and sending to the worker, which deserializes it and executes as a callback within its own context.

@insof
Copy link

insof commented Sep 17, 2021

Any news about this feature?
We need it!

@yaustar
Copy link
Collaborator

yaustar commented Sep 17, 2021

@insof I'm afraid this is not planned on the road map yet. The upcoming public Editor API should make it easier to integrate a 3rd party physics system though

@querielo
Copy link
Contributor

querielo commented Nov 9, 2022

Any update here? It would be great to have an adapter between the engine components and physics engine.

The latest news: https://developer.nvidia.com/blog/open-source-simulation-expands-with-nvidia-physx-5-release/

@yaustar
Copy link
Collaborator

yaustar commented Nov 9, 2022

I'm afraid no changes/updates. We are looking at implementing #4767 and with that, some Editor updates to allow a more modular way of building a project. (Tree shaking etc) And with that, it will make it easier for others to add a Rapier Component System.

Combined with Editor Plugins/API, it could make swapping out the physics more possible on a per project basis, just not in the same way when this ticket was first created was envisioning it.

@issacclee
Copy link

Hi Guys,

The latest version of Babylon.js supports the newly released web version of Havok physic Engine. Some demos showed promising results with huge performance boost(three.js community put together a binding for Havok as well).

some examples https://playground.babylonjs.com/#PX6E6C

Maybe we should consider support Havok when we starts to make the effort to decouple physic engine from main playcanvas engine.

@willeastcott
Copy link
Contributor

@issacclee In case you missed my tweet: https://twitter.com/willeastcott/status/1650931998146306072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: physics Physics related issue feature
Projects
None yet
Development

No branches or pull requests

7 participants