Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass sorted lights to custom materials #5311

Closed
GSterbrant opened this issue May 9, 2023 · 1 comment
Closed

Pass sorted lights to custom materials #5311

GSterbrant opened this issue May 9, 2023 · 1 comment
Assignees
@GSterbrant
Labels
area: graphics Graphics related issue feature
Milestone
Q3 2023

Comments

@GSterbrant
Copy link
Contributor

Lights are passed to the standard-material through the getShaderVariant call, which is invoked from the MeshInstance updatePassShader from the ForwardRenderer when we know all the sorted lights.

To support having a custom frontend with our lit backend on any material, we need some way of having these lights passed to a custom material as well.

Relates to #4250.
@GSterbrant GSterbrant added feature area: graphics Graphics related issue labels May 9, 2023
@GSterbrant GSterbrant changed the title Allow for material to get lights passed to lit shader backend. Pass sorted lights to custom materials. May 9, 2023
@GSterbrant GSterbrant changed the title Pass sorted lights to custom materials. Pass sorted lights to custom materials May 9, 2023
@willeastcott willeastcott added this to the Q2 2023 milestone May 9, 2023
@mvaligursky
Copy link
Contributor

done, mostly in #5445

@willeastcott willeastcott modified the milestones: Q2 2023, Q3 2023 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GSterbrant GSterbrant

Labels
area: graphics Graphics related issue feature
Projects
PlayCanvas Roadmap
Status: Done
Milestone
Q3 2023
Development

No branches or pull requests
3 participants
@willeastcott @mvaligursky @GSterbrant