Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add footer in info component #175

Closed
wants to merge 2 commits into from
Closed

Add footer in info component #175

wants to merge 2 commits into from

Conversation

vg300
Copy link

@vg300 vg300 commented Oct 8, 2023

Change Type (required)

Add footer in the info component

Fixes #161

@vg300 vg300 requested a review from adierkens as a code owner October 8, 2023 09:13
@vg300
Copy link
Author

vg300 commented Oct 8, 2023

Hi @hborawski, can you please review this and let me know if anything else is required?

@hborawski
Copy link
Contributor

@vg300 Hey sorry for the delay, been under the weather the last few days.

It looks like the lint stage is failing, which should be reproducible by running bazel test //... or running bazel test //plugins/reference-assets/react/...

Additionally, to exercise this new functionality, can you please add a new mock, or update an existing mock here so it can be viewed in Storybook

@vg300
Copy link
Author

vg300 commented Oct 19, 2023

Hi @hborawski, thanks for your review. I have updated the mocks, please let me know if there's anything else required. I was unable to run the bazel test command locally..could you pls tell me how to fix it?

@mercillo
Copy link
Contributor

hey @vg300 ! it looks like some of your tests are still failing.

//plugins/reference-assets/react:@player-ui/reference-assets-plugin-react-lint FAILED in 5.7s

what errors are you getting running the bazel test command?

@KetanReddy KetanReddy closed this Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React: Add footer to info reference asset
4 participants